From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: Re: [PATCH v16 04/26] blk-zoned: Only handle errors after pending zoned writes have completed
Date: Sun, 24 Nov 2024 23:33:39 +0800 [thread overview]
Message-ID: <202411242326.HSKyGmyJ-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241119002815.600608-5-bvanassche@acm.org>
References: <20241119002815.600608-5-bvanassche@acm.org>
TO: Bart Van Assche <bvanassche@acm.org>
Hi Bart,
kernel test robot noticed the following build warnings:
[auto build test WARNING on linus/master]
[also build test WARNING on next-20241122]
[cannot apply to jejb-scsi/for-next mkp-scsi/for-next v6.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]
url: https://github.com/intel-lab-lkp/linux/commits/Bart-Van-Assche/blk-zoned-Fix-a-reference-count-leak/20241121-112830
base: linus/master
patch link: https://lore.kernel.org/r/20241119002815.600608-5-bvanassche%40acm.org
patch subject: [PATCH v16 04/26] blk-zoned: Only handle errors after pending zoned writes have completed
:::::: branch date: 4 days ago
:::::: commit date: 4 days ago
config: microblaze-randconfig-r072-20241124 (https://download.01.org/0day-ci/archive/20241124/202411242326.HSKyGmyJ-lkp@intel.com/config)
compiler: microblaze-linux-gcc (GCC) 14.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411242326.HSKyGmyJ-lkp@intel.com/
New smatch warnings:
block/blk-zoned.c:804 blk_zone_all_zwr_inserted() warn: iterator 'i' not incremented
Old smatch warnings:
arch/microblaze/include/asm/thread_info.h:85 current_thread_info() error: uninitialized symbol 'sp'.
vim +/i +804 block/blk-zoned.c
2238dfb90653aa Bart Van Assche 2024-11-18 779
2238dfb90653aa Bart Van Assche 2024-11-18 780 /*
2238dfb90653aa Bart Van Assche 2024-11-18 781 * Report whether or not all zoned writes for a zone have been inserted into a
2238dfb90653aa Bart Van Assche 2024-11-18 782 * software queue, elevator queue or hardware queue.
2238dfb90653aa Bart Van Assche 2024-11-18 783 */
2238dfb90653aa Bart Van Assche 2024-11-18 784 static bool blk_zone_all_zwr_inserted(struct blk_zone_wplug *zwplug)
2238dfb90653aa Bart Van Assche 2024-11-18 785 {
2238dfb90653aa Bart Van Assche 2024-11-18 786 struct gendisk *disk = zwplug->disk;
2238dfb90653aa Bart Van Assche 2024-11-18 787 struct request_queue *q = disk->queue;
2238dfb90653aa Bart Van Assche 2024-11-18 788 struct all_zwr_inserted_data d = { .zwplug = zwplug, .res = true };
2238dfb90653aa Bart Van Assche 2024-11-18 789 struct blk_mq_hw_ctx *hctx;
2238dfb90653aa Bart Van Assche 2024-11-18 790 long unsigned int i;
2238dfb90653aa Bart Van Assche 2024-11-18 791 struct request *rq;
2238dfb90653aa Bart Van Assche 2024-11-18 792
2238dfb90653aa Bart Van Assche 2024-11-18 793 scoped_guard(spinlock_irqsave, &q->requeue_lock) {
2238dfb90653aa Bart Van Assche 2024-11-18 794 list_for_each_entry(rq, &q->requeue_list, queuelist)
2238dfb90653aa Bart Van Assche 2024-11-18 795 if (blk_rq_is_seq_zoned_write(rq) &&
2238dfb90653aa Bart Van Assche 2024-11-18 796 bio_zone_no(rq->bio) == zwplug->zone_no)
2238dfb90653aa Bart Van Assche 2024-11-18 797 return false;
2238dfb90653aa Bart Van Assche 2024-11-18 798 list_for_each_entry(rq, &q->flush_list, queuelist)
2238dfb90653aa Bart Van Assche 2024-11-18 799 if (blk_rq_is_seq_zoned_write(rq) &&
2238dfb90653aa Bart Van Assche 2024-11-18 800 bio_zone_no(rq->bio) == zwplug->zone_no)
2238dfb90653aa Bart Van Assche 2024-11-18 801 return false;
2238dfb90653aa Bart Van Assche 2024-11-18 802 }
2238dfb90653aa Bart Van Assche 2024-11-18 803
2238dfb90653aa Bart Van Assche 2024-11-18 @804 queue_for_each_hw_ctx(q, hctx, i) {
2238dfb90653aa Bart Van Assche 2024-11-18 805 struct blk_mq_tags *tags = hctx->sched_tags ?: hctx->tags;
2238dfb90653aa Bart Van Assche 2024-11-18 806
2238dfb90653aa Bart Van Assche 2024-11-18 807 blk_mq_all_tag_iter(tags, blk_zwr_inserted, &d);
2238dfb90653aa Bart Van Assche 2024-11-18 808 if (!d.res || blk_mq_is_shared_tags(q->tag_set->flags))
2238dfb90653aa Bart Van Assche 2024-11-18 809 break;
2238dfb90653aa Bart Van Assche 2024-11-18 810 }
2238dfb90653aa Bart Van Assche 2024-11-18 811
2238dfb90653aa Bart Van Assche 2024-11-18 812 return d.res;
2238dfb90653aa Bart Van Assche 2024-11-18 813 }
2238dfb90653aa Bart Van Assche 2024-11-18 814
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-11-24 15:34 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-24 15:33 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2024-11-19 0:27 [PATCH v16 00/26] Improve write performance for zoned UFS devices Bart Van Assche
2024-11-19 0:27 ` [PATCH v16 04/26] blk-zoned: Only handle errors after pending zoned writes have completed Bart Van Assche
2024-11-19 2:50 ` Damien Le Moal
2024-11-19 20:51 ` Bart Van Assche
2024-11-21 3:23 ` Damien Le Moal
2024-11-21 17:43 ` Bart Van Assche
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411242326.HSKyGmyJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.