From: Christoph Hellwig <hch@lst.de>
To: "brookxu.cn" <brookxu.cn@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 4/5] nvme-tcp: remove nvme_tcp_destroy_io_queues()
Date: Mon, 25 Nov 2024 08:24:00 +0100 [thread overview]
Message-ID: <20241125072400.GD15647@lst.de> (raw)
In-Reply-To: <5afd7d60a07afc6f299aba8c31fe87e00484da5b.1732368538.git.chunguang.xu@shopee.com>
On Sat, Nov 23, 2024 at 09:37:40PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@shopee.com>
>
> Now maybe we can remove nvme_tcp_destroy_io_queues() to simplify
> the code and avoid unnecessary call of nvme_tcp_stop_io_queues().
Please split the behavior change from the cleanup, and explain why
the behavior change is fine and desirable.
next prev parent reply other threads:[~2024-11-25 7:24 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <cover.1732368538.git.chunguang.xu@shopee.com>
2024-11-23 13:37 ` [PATCH 1/5] nvme-rdma: unquiesce admin_q before destroy it brookxu.cn
2024-11-25 7:21 ` Christoph Hellwig
2024-11-29 11:18 ` Hannes Reinecke
2024-12-24 11:53 ` Sagi Grimberg
2024-11-23 13:37 ` [PATCH 2/5] nvme-tcp: no need to quiesec admin_q in nvme_tcp_teardown_io_queues() brookxu.cn
2024-11-25 7:22 ` Christoph Hellwig
2024-11-25 7:55 ` 许春光
2024-11-29 11:18 ` Hannes Reinecke
2024-11-23 13:37 ` [PATCH 3/5] nvme-tcp: simplify nvme_tcp_configure_admin_queue() brookxu.cn
2024-11-25 7:22 ` Christoph Hellwig
2024-11-29 11:19 ` Hannes Reinecke
2024-11-23 13:37 ` [PATCH 4/5] nvme-tcp: remove nvme_tcp_destroy_io_queues() brookxu.cn
2024-11-25 7:24 ` Christoph Hellwig [this message]
2024-11-25 7:51 ` 许春光
2024-11-29 11:22 ` Hannes Reinecke
2024-11-23 13:37 ` [PATCH 5/5] nvme-tcp: fix the memleak while create new ctrl failed brookxu.cn
2024-11-25 7:25 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125072400.GD15647@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.