From: Masami Hiramatsu (Google) <mhiramat@kernel.org>
To: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Cc: "Thomas Weißschuh" <thomas.weissschuh@linutronix.de>,
"Naveen N Rao" <naveen@kernel.org>,
"Anil S Keshavamurthy" <anil.s.keshavamurthy@intel.com>,
"David S. Miller" <davem@davemloft.net>,
"Masami Hiramatsu" <mhiramat@kernel.org>,
"Clark Williams" <clrkwllms@kernel.org>,
"Steven Rostedt" <rostedt@goodmis.org>,
linux-kernel@vger.kernel.org, linux-trace-kernel@vger.kernel.org,
linux-rt-devel@lists.linux.dev
Subject: Re: [PATCH] kprobes: Reduce preempt disable scope in check_kprobe_access_safe()
Date: Mon, 25 Nov 2024 14:24:58 +0900 [thread overview]
Message-ID: <20241125142458.9ed23f07da4eaf732cfa9a8e@kernel.org> (raw)
In-Reply-To: <20241121080432.ysLlZsSP@linutronix.de>
On Thu, 21 Nov 2024 09:04:32 +0100
Sebastian Andrzej Siewior <bigeasy@linutronix.de> wrote:
> On 2024-11-21 08:38:08 [+0100], Thomas Weißschuh wrote:
> …
> > Signed-off-by: Thomas Weißschuh <thomas.weissschuh@linutronix.de>
>
> Reviewed-by: Sebastian Andrzej Siewior <bigeasy@linutronix.de>
Thanks for your review!
>
> > diff --git a/kernel/kprobes.c b/kernel/kprobes.c
> > index da59c68df8412c4662d39d3e286d516e8cee9a69..369020170e832a34ea9c05eda6693bded02ec505 100644
> > --- a/kernel/kprobes.c
> > +++ b/kernel/kprobes.c
> > @@ -39,6 +39,7 @@
> > #include <linux/static_call.h>
> > #include <linux/perf_event.h>
> > #include <linux/execmem.h>
> > +#include <linux/cleanup.h>
>
> This hunk can be dropped. The definition for guard(preempt)() comes from
> preempt.h.
>
> > #include <asm/sections.h>
> > #include <asm/cacheflush.h>
>
> Sebastian
--
Masami Hiramatsu (Google) <mhiramat@kernel.org>
next prev parent reply other threads:[~2024-11-25 5:25 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-21 7:38 [PATCH] kprobes: Reduce preempt disable scope in check_kprobe_access_safe() Thomas Weißschuh
2024-11-21 8:04 ` Sebastian Andrzej Siewior
2024-11-25 5:24 ` Masami Hiramatsu [this message]
2024-11-25 5:25 ` Masami Hiramatsu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125142458.9ed23f07da4eaf732cfa9a8e@kernel.org \
--to=mhiramat@kernel.org \
--cc=anil.s.keshavamurthy@intel.com \
--cc=bigeasy@linutronix.de \
--cc=clrkwllms@kernel.org \
--cc=davem@davemloft.net \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rt-devel@lists.linux.dev \
--cc=linux-trace-kernel@vger.kernel.org \
--cc=naveen@kernel.org \
--cc=rostedt@goodmis.org \
--cc=thomas.weissschuh@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.