From: Eric Biggers <ebiggers@kernel.org>
To: Allison Karlitskaya <allison.karlitskaya@redhat.com>
Cc: "Theodore Y . Ts'o" <tytso@mit.edu>,
linux-btrfs@vger.kernel.org, fsverity@lists.linux.dev
Subject: Re: [PATCH] btrfs: add FS_IOC_READ_VERITY_METADATA ioctl
Date: Mon, 25 Nov 2024 18:11:17 +0000 [thread overview]
Message-ID: <20241125181117.GB1242949@google.com> (raw)
In-Reply-To: <20241125084111.141386-1-allison.karlitskaya@redhat.com>
On Mon, Nov 25, 2024 at 09:41:11AM +0100, Allison Karlitskaya wrote:
> e17fe6579de0 introduced FS_IOC_READ_VERITY_METADATA to directly query
> the Merkle tree, descriptor and signature blocks for fs-verity enabled
> files. It also added the ioctl implementation to ext4 and f2fs, but
> seems to have forgotten about btrfs.
At the time, btrfs did not support fs-verity.
>
> Add the (trival) implementation for btrfs: we just need to wire it
> through to the fs-verity code, the same way as was done for the other
> two filesystems. The fs-verity code already has access to the required
> data.
This ioctl isn't too useful, but I suppose adding it to btrfs can't hurt.
Can you run xfstests generic/624 and generic/625, which test this ioctl?
- Eric
next prev parent reply other threads:[~2024-11-25 18:11 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-25 8:41 [PATCH] btrfs: add FS_IOC_READ_VERITY_METADATA ioctl Allison Karlitskaya
2024-11-25 18:11 ` Eric Biggers [this message]
2024-11-25 20:06 ` Allison Karlitskaya
2024-11-26 2:33 ` Eric Biggers
2024-11-26 8:48 ` [PATCH] Documentation: add a usecase for FS_IOC_READ_VERITY_METADATA Allison Karlitskaya
2025-02-17 19:35 ` Eric Biggers
2024-11-26 9:01 ` [PATCH] btrfs: add FS_IOC_READ_VERITY_METADATA ioctl Allison Karlitskaya
2024-11-26 15:11 ` David Sterba
2024-11-26 15:23 ` Allison Karlitskaya
2024-11-26 16:23 ` David Sterba
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241125181117.GB1242949@google.com \
--to=ebiggers@kernel.org \
--cc=allison.karlitskaya@redhat.com \
--cc=fsverity@lists.linux.dev \
--cc=linux-btrfs@vger.kernel.org \
--cc=tytso@mit.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.