All of lore.kernel.org
 help / color / mirror / Atom feed
From: Al Viro <viro@zeniv.linux.org.uk>
To: Greg KH <gregkh@linuxfoundation.org>
Cc: Nanyong Sun <sunnanyong@huawei.com>,
	cve@kernel.org, linux-cve-announce@vger.kernel.org,
	linux-kernel@vger.kernel.org, aha310510@gmail.com,
	Hugh Dickins <hughd@google.com>
Subject: Re: CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr()
Date: Mon, 25 Nov 2024 21:29:46 +0000	[thread overview]
Message-ID: <20241125212946.GE3387508@ZenIV> (raw)
In-Reply-To: <2024112552-wish-oboe-1b91@gregkh>

On Mon, Nov 25, 2024 at 10:16:37PM +0100, Greg KH wrote:
> On Mon, Nov 25, 2024 at 03:49:44PM +0800, Nanyong Sun wrote:
> > Hi Greg,
> >   Will this CVE be rejected in the future? This patch has introduced a
> > problem and has been reverted:
> > https://lore.kernel.org/all/20241116233053.F1FBAC4CEC3@smtp.kernel.org/T/
> > 
> 
> What is the git commit id of this change?  Is it in Linus's tree yet?
> And did the original syzbot splat get fixed some other way?

Revert in mainline is d1aa0c04294e29883d65eac6c2f72fe95cc7c049; patch
had really been pointless and we'd better watch out for its analogues
being introduced.

IMO "fixes a data-race" in patch description has become a serious red flag
for review by now.  Some of them are valid, some are pointless and occasionally
actively harmful.

  reply	other threads:[~2024-11-25 21:29 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-09 10:15 CVE-2024-50228: mm: shmem: fix data-race in shmem_getattr() Greg Kroah-Hartman
2024-11-25  7:49 ` Nanyong Sun
2024-11-25 21:16   ` Greg KH
2024-11-25 21:29     ` Al Viro [this message]
2024-11-28 16:52       ` Greg KH

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241125212946.GE3387508@ZenIV \
    --to=viro@zeniv.linux.org.uk \
    --cc=aha310510@gmail.com \
    --cc=cve@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=hughd@google.com \
    --cc=linux-cve-announce@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=sunnanyong@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.