Re: [LTP] [PATCH v2 5/5] setsockopt0[38]: Use tst_is_compat_mode()

[Petr Vorel <pvorel@suse.cz>]

Hi Cyril,

> Hi!
> > > I guess this is something that should be looked into after the release,
> > > either we will need .needs_compat flag or relax the condtions...

> > Looking into this old patch, do we relax the conditions or use .needs_abi_bits = 32?
> > setsockopt08.c prints only TINFO, thus !tst_is_compat_mode() would have to be
> > used for the check.

> I guess that doing:

> 	if (!tst_is_compat_mode())
> 		tst_res(TINFO, "The vunerability was only present in 32-bit compat mode");


> Is a sensible approach. It does not hurt to run the test either way but
> it makes it clear that the original CVE it's not going to be reproduced
> without 32-bit compat mode.

+1. I modified that and dared to merge with your RBT (9dacb1ac27).
Thanks for your review!

Kind regards,
Petr


-- 
Mailing list info: https://lists.linux.it/listinfo/ltp