From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: fs/smb/server/oplock.c:1000 find_same_lease_key() warn: missing error code 'err'
Date: Tue, 26 Nov 2024 17:40:14 +0800 [thread overview]
Message-ID: <202411261753.E6AvIsTJ-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Steve French <stfrench@microsoft.com>
Hi Steve,
First bad commit (maybe != root cause):
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: 7eef7e306d3c40a0c5b9ff6adc9b273cc894dbd5
commit: 38c8a9a52082579090e34c033d439ed2cd1a462d smb: move client and server files to common directory fs/smb
date: 1 year, 6 months ago
:::::: branch date: 7 hours ago
:::::: commit date: 1 year, 6 months ago
config: x86_64-randconfig-161-20241120 (https://download.01.org/0day-ci/archive/20241126/202411261753.E6AvIsTJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411261753.E6AvIsTJ-lkp@intel.com/
smatch warnings:
fs/smb/server/oplock.c:1000 find_same_lease_key() warn: missing error code 'err'
vim +/err +1000 fs/smb/server/oplock.c
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 967
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 968 int find_same_lease_key(struct ksmbd_session *sess, struct ksmbd_inode *ci,
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 969 struct lease_ctx_info *lctx)
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 970 {
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 971 struct oplock_info *opinfo;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 972 int err = 0;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 973 struct lease_table *lb;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 974
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 975 if (!lctx)
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 976 return err;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 977
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 978 read_lock(&lease_list_lock);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 979 if (list_empty(&lease_table_list)) {
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 980 read_unlock(&lease_list_lock);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 981 return 0;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 982 }
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 983
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 984 list_for_each_entry(lb, &lease_table_list, l_entry) {
af7c39d971e43c fs/ksmbd/oplock.c Namjae Jeon 2022-07-25 985 if (!memcmp(lb->client_guid, sess->ClientGUID,
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 986 SMB2_CLIENT_GUID_SIZE))
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 987 goto found;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 988 }
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 989 read_unlock(&lease_list_lock);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 990
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 991 return 0;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 992
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 993 found:
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 994 rcu_read_lock();
070fb21e5912b6 fs/cifsd/oplock.c Namjae Jeon 2021-05-26 995 list_for_each_entry_rcu(opinfo, &lb->lease_list, lease_entry) {
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 996 if (!atomic_inc_not_zero(&opinfo->refcount))
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 997 continue;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 998 rcu_read_unlock();
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 999 if (opinfo->o_fp->f_ci == ci)
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 @1000 goto op_next;
af7c39d971e43c fs/ksmbd/oplock.c Namjae Jeon 2022-07-25 1001 err = compare_guid_key(opinfo, sess->ClientGUID,
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1002 lctx->lease_key);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1003 if (err) {
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1004 err = -EINVAL;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1005 ksmbd_debug(OPLOCK,
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1006 "found same lease key is already used in other files\n");
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1007 opinfo_put(opinfo);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1008 goto out;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1009 }
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1010 op_next:
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1011 opinfo_put(opinfo);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1012 rcu_read_lock();
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1013 }
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1014 rcu_read_unlock();
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1015
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1016 out:
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1017 read_unlock(&lease_list_lock);
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1018 return err;
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1019 }
e2f34481b24db2 fs/cifsd/oplock.c Namjae Jeon 2021-03-16 1020
:::::: The code at line 1000 was first introduced by commit
:::::: e2f34481b24db2fd634b5edb0a5bd0e4d38cc6e9 cifsd: add server-side procedures for SMB3
:::::: TO: Namjae Jeon <namjae.jeon@samsung.com>
:::::: CC: Steve French <stfrench@microsoft.com>
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
next reply other threads:[~2024-11-26 9:41 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 9:40 kernel test robot [this message]
-- strict thread matches above, loose matches on Subject: below --
2023-10-11 2:26 fs/smb/server/oplock.c:1000 find_same_lease_key() warn: missing error code 'err' kernel test robot
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202411261753.E6AvIsTJ-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.