[openeuler:OLK-5.10 2490/2490] drivers/thermal/intel/intel_hfi.c:245 hfi_update_work_fn() warn: can 'hfi_instance' even be NULL?

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
TO: kernel@openeuler.org
TO: Jun Tian <jun.j.tian@intel.com>

Hi Srinivas,

First bad commit (maybe != root cause):

tree:   https://gitee.com/openeuler/kernel.git OLK-5.10
head:   68b0fb4e955465eef28bed1f5a252c4e6c636a36
commit: d1b287f6c142193c6dc5a5abfe2fe59e2f03cee6 [2490/2490] thermal: netlink: Add a new event to notify CPU capabilities change
:::::: branch date: 7 hours ago
:::::: commit date: 2 years, 5 months ago
config: x86_64-randconfig-161-20241127 (https://download.01.org/0day-ci/archive/20241127/202411272348.6eld5bPC-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202411272348.6eld5bPC-lkp@intel.com/

smatch warnings:
drivers/thermal/intel/intel_hfi.c:245 hfi_update_work_fn() warn: can 'hfi_instance' even be NULL?

vim +/hfi_instance +245 drivers/thermal/intel/intel_hfi.c

07dc6e0b04d8ec Ricardo Neri        2022-01-27  238  
07dc6e0b04d8ec Ricardo Neri        2022-01-27  239  static void hfi_update_work_fn(struct work_struct *work)
07dc6e0b04d8ec Ricardo Neri        2022-01-27  240  {
07dc6e0b04d8ec Ricardo Neri        2022-01-27  241  	struct hfi_instance *hfi_instance;
07dc6e0b04d8ec Ricardo Neri        2022-01-27  242  
07dc6e0b04d8ec Ricardo Neri        2022-01-27  243  	hfi_instance = container_of(to_delayed_work(work), struct hfi_instance,
07dc6e0b04d8ec Ricardo Neri        2022-01-27  244  				    update_work);
07dc6e0b04d8ec Ricardo Neri        2022-01-27 @245  	if (!hfi_instance)
07dc6e0b04d8ec Ricardo Neri        2022-01-27  246  		return;
07dc6e0b04d8ec Ricardo Neri        2022-01-27  247  
b0b8a4822c7764 Srinivas Pandruvada 2022-01-27  248  	update_capabilities(hfi_instance);
07dc6e0b04d8ec Ricardo Neri        2022-01-27  249  }
07dc6e0b04d8ec Ricardo Neri        2022-01-27  250  

:::::: The code at line 245 was first introduced by commit
:::::: 07dc6e0b04d8eca2963e138452d5b24af8f82b28 thermal: intel: hfi: Enable notification interrupt

:::::: TO: Ricardo Neri <ricardo.neri-calderon@linux.intel.com>
:::::: CC: Jun Tian <jun.j.tian@intel.com>

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki