Re: [yocto-patches] [meta-rockchip PATCH 1/2] bsp: rkbin: rkbin-ddr: use glob pattern for finding DDR init

[Trevor Woerner <twoerner@gmail.com>]

On Wed 2024-11-27 @ 04:12:58 PM, Quentin Schulz via lists.yoctoproject.org wrote:
> From: Quentin Schulz <quentin.schulz@cherry.de>
> 
> To avoid both having to modify this file every time the
> rockchip-rbin.inc SRCREV is bumped and also having to override it were
> a user to have to mix and match versions for different products, let's
> just use a glob pattern.
> 
> Note that the glob pattern should only match one path, which is the case
> right now.

I'm not overly fond of the glob method. It was only back in June of this
year that I pushed a patch to move away from globs to using full filenames
explicitly. The savings seem pretty thin compared to the potential surprise
factor when, one day, multiple files might be selected.

Do you feel strongly about switching back to the glob?

> Signed-off-by: Quentin Schulz <quentin.schulz@cherry.de>
> ---
>  recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb b/recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb
> index 0ff71320de8cfeee259a820a07375f490d1086d6..a22c7e12c32b5e1988e8e6b870b94cf9438f23ae 100644
> --- a/recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb
> +++ b/recipes-bsp/rkbin/rockchip-rkbin-ddr_git.bb
> @@ -9,15 +9,15 @@ do_deploy:rk3308() {
>  
>  do_deploy:rk3566() {
>  	# Prebuilt U-Boot TPL (DDR init)
> -	install -m 644 ${S}/bin/rk35/rk3566_ddr_1056MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3566.bin
> +	install -m 644 ${S}/bin/rk35/rk3566_ddr_1056MHz_v*.bin ${DEPLOYDIR}/ddr-rk3566.bin
>  }
>  
>  do_deploy:rk3568() {
>  	# Prebuilt U-Boot TPL (DDR init)
> -	install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v1.21.bin ${DEPLOYDIR}/ddr-rk3568.bin
> +	install -m 644 ${S}/bin/rk35/rk3568_ddr_1560MHz_v*.bin ${DEPLOYDIR}/ddr-rk3568.bin
>  }
>  
>  do_deploy:rk3588s() {
>  	# Prebuilt U-Boot TPL (DDR init)
> -	install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v1.16.bin ${DEPLOYDIR}/ddr-rk3588.bin
> +	install -m 644 ${S}/bin/rk35/rk3588_ddr_lp4_2112MHz_lp5_2400MHz_v*.bin ${DEPLOYDIR}/ddr-rk3588.bin
>  }
> 
> -- 
> 2.47.0
> 
> 
> 
> -=-=-=-=-=-=-=-=-=-=-=-
> Links: You receive all messages sent to this group.
> View/Reply Online (#844): https://lists.yoctoproject.org/g/yocto-patches/message/844
> Mute This Topic: https://lists.yoctoproject.org/mt/109807515/900817
> Group Owner: yocto-patches+owner@lists.yoctoproject.org
> Unsubscribe: https://lists.yoctoproject.org/g/yocto-patches/leave/13168745/900817/63955952/xyzzy [twoerner@gmail.com]
> -=-=-=-=-=-=-=-=-=-=-=-
> 
>