Re: [PATCH] fs: don't block write during exec on pre-content watched files

[kernel test robot <lkp@intel.com>]

Hi Amir,

kernel test robot noticed the following build errors:

[auto build test ERROR on linus/master]
[also build test ERROR on next-20241128]
[cannot apply to kees/for-next/execve brauner-vfs/vfs.all jack-fs/for_next v6.12]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Amir-Goldstein/fs-don-t-block-write-during-exec-on-pre-content-watched-files/20241128-222743
base:   linus/master
patch link:    https://lore.kernel.org/r/20241128142532.465176-1-amir73il%40gmail.com
patch subject: [PATCH] fs: don't block write during exec on pre-content watched files
config: powerpc-taishan_defconfig (https://download.01.org/0day-ci/archive/20241129/202411290029.NPdQREi1-lkp@intel.com/config)
compiler: clang version 20.0.0git (https://github.com/llvm/llvm-project 592c0fe55f6d9a811028b5f3507be91458ab2713)
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411290029.NPdQREi1-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411290029.NPdQREi1-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from arch/powerpc/kernel/asm-offsets.c:12:
   In file included from include/linux/compat.h:17:
>> include/linux/fs.h:3068:15: error: call to undeclared function 'FMODE_FSNOTIFY_HSM'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    3068 |         if (unlikely(FMODE_FSNOTIFY_HSM(exe_file->f_mode)))
         |                      ^
   include/linux/fs.h:3074:15: error: call to undeclared function 'FMODE_FSNOTIFY_HSM'; ISO C99 and later do not support implicit function declarations [-Wimplicit-function-declaration]
    3074 |         if (unlikely(FMODE_FSNOTIFY_HSM(exe_file->f_mode)))
         |                      ^
   In file included from arch/powerpc/kernel/asm-offsets.c:19:
   In file included from include/linux/mman.h:6:
   In file included from include/linux/mm.h:2223:
   include/linux/vmstat.h:518:36: warning: arithmetic between different enumeration types ('enum node_stat_item' and 'enum lru_list') [-Wenum-enum-conversion]
     518 |         return node_stat_name(NR_LRU_BASE + lru) + 3; // skip "nr_"
         |                               ~~~~~~~~~~~ ^ ~~~
   In file included from arch/powerpc/kernel/asm-offsets.c:19:
   include/linux/mman.h:158:9: warning: division by zero is undefined [-Wdivision-by-zero]
     158 |                _calc_vm_trans(flags, MAP_LOCKED,     VM_LOCKED    ) |
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/mman.h:137:21: note: expanded from macro '_calc_vm_trans'
     137 |    : ((x) & (bit1)) / ((bit1) / (bit2))))
         |                     ^ ~~~~~~~~~~~~~~~~~
   include/linux/mman.h:159:9: warning: division by zero is undefined [-Wdivision-by-zero]
     159 |                _calc_vm_trans(flags, MAP_SYNC,       VM_SYNC      ) |
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/mman.h:137:21: note: expanded from macro '_calc_vm_trans'
     137 |    : ((x) & (bit1)) / ((bit1) / (bit2))))
         |                     ^ ~~~~~~~~~~~~~~~~~
   include/linux/mman.h:160:9: warning: division by zero is undefined [-Wdivision-by-zero]
     160 |                _calc_vm_trans(flags, MAP_STACK,      VM_NOHUGEPAGE) |
         |                ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/mman.h:137:21: note: expanded from macro '_calc_vm_trans'
     137 |    : ((x) & (bit1)) / ((bit1) / (bit2))))
         |                     ^ ~~~~~~~~~~~~~~~~~
   4 warnings and 2 errors generated.
   make[3]: *** [scripts/Makefile.build:102: arch/powerpc/kernel/asm-offsets.s] Error 1
   make[3]: Target 'prepare' not remade because of errors.
   make[2]: *** [Makefile:1211: prepare0] Error 2
   make[2]: Target 'prepare' not remade because of errors.
   make[1]: *** [Makefile:224: __sub-make] Error 2
   make[1]: Target 'prepare' not remade because of errors.
   make: *** [Makefile:224: __sub-make] Error 2
   make: Target 'prepare' not remade because of errors.


vim +/FMODE_FSNOTIFY_HSM +3068 include/linux/fs.h

  3062	
  3063	/*
  3064	 * Do not prevent write to executable file when watched by pre-content events.
  3065	 */
  3066	static inline int exe_file_deny_write_access(struct file *exe_file)
  3067	{
> 3068		if (unlikely(FMODE_FSNOTIFY_HSM(exe_file->f_mode)))
  3069			return 0;
  3070		return deny_write_access(exe_file);
  3071	}
  3072	static inline void exe_file_allow_write_access(struct file *exe_file)
  3073	{
  3074		if (unlikely(FMODE_FSNOTIFY_HSM(exe_file->f_mode)))
  3075			return;
  3076		allow_write_access(exe_file);
  3077	}
  3078	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki