All of lore.kernel.org
 help / color / mirror / Atom feed
From: kernel test robot <lkp@intel.com>
To: Asahi Lina <lina@asahilina.net>
Cc: oe-kbuild-all@lists.linux.dev, Janne Grunau <j@jannau.net>
Subject: [asahilinux:gpu/feat-gettime 574/1045] drivers/gpu/drm/drm_gpuvm.c:2680: warning: Function parameter or struct member 'priv' not described in 'drm_gpuvm_bo_unmap'
Date: Fri, 29 Nov 2024 02:02:22 +0800	[thread overview]
Message-ID: <202411290104.HClHBf40-lkp@intel.com> (raw)

tree:   https://github.com/AsahiLinux/linux gpu/feat-gettime
head:   cecfe574a0faf4c21d6f7a99cbf076223d7a04e6
commit: 3071faed85b4c2fc9d6de681d2059c02d56388ef [574/1045] drm/gpuvm: Add drm_gpuvm_bo_unmap()
config: x86_64-rhel-9.4 (https://download.01.org/0day-ci/archive/20241129/202411290104.HClHBf40-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241129/202411290104.HClHBf40-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202411290104.HClHBf40-lkp@intel.com/

All warnings (new ones prefixed by >>):

>> drivers/gpu/drm/drm_gpuvm.c:2680: warning: Function parameter or struct member 'priv' not described in 'drm_gpuvm_bo_unmap'


vim +2680 drivers/gpu/drm/drm_gpuvm.c

  2666	
  2667	/**
  2668	 * drm_gpuvm_bo_unmap() - unmaps a GEM
  2669	 * @vm_bo: the &drm_gpuvm_bo abstraction
  2670	 *
  2671	 * This function calls the unmap callback for every GPUVA attached to a GEM.
  2672	 *
  2673	 * It is the callers responsibility to protect the GEMs GPUVA list against
  2674	 * concurrent access using the GEMs dma_resv lock.
  2675	 *
  2676	 * Returns: a pointer to the &drm_gpuva_ops on success, an ERR_PTR on failure
  2677	 */
  2678	int
  2679	drm_gpuvm_bo_unmap(struct drm_gpuvm_bo *vm_bo, void *priv)
> 2680	{
  2681		struct drm_gpuva_op *op;
  2682		int ret;
  2683	
  2684		if (unlikely(!vm_bo->vm))
  2685			return -EINVAL;
  2686	
  2687		const struct drm_gpuvm_ops *vm_ops = vm_bo->vm->ops;
  2688	
  2689		if (unlikely(!(vm_ops && vm_ops->sm_step_unmap)))
  2690			return -EINVAL;
  2691	
  2692		struct drm_gpuva_ops *ops = drm_gpuvm_bo_unmap_ops_create(vm_bo);
  2693	        if (IS_ERR(ops))
  2694	                return PTR_ERR(ops);
  2695	
  2696		drm_gpuva_for_each_op(op, ops) {
  2697			drm_WARN_ON(vm_bo->vm->drm, op->op != DRM_GPUVA_OP_UNMAP);
  2698	
  2699			ret = op_unmap_cb(vm_ops, priv, op->unmap.va, false);
  2700			if (ret)
  2701				goto cleanup;
  2702		}
  2703	
  2704	cleanup:
  2705		drm_gpuva_ops_free(vm_bo->vm, ops);
  2706		return ret;
  2707	}
  2708	EXPORT_SYMBOL_GPL(drm_gpuvm_bo_unmap);
  2709	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki

                 reply	other threads:[~2024-11-28 18:03 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=202411290104.HClHBf40-lkp@intel.com \
    --to=lkp@intel.com \
    --cc=j@jannau.net \
    --cc=lina@asahilina.net \
    --cc=oe-kbuild-all@lists.linux.dev \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.