drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c:667:42-46: ERROR: invalid reference to the index variable of the iterator on line 656

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Ben Skeggs <bskeggs@redhat.com>
CC: Dave Airlie <airlied@redhat.com>

tree:   https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head:   b86545e02e8c22fb89218f29d381fa8e8b91d815
commit: 9e99444490238d210a421cef3598432c5da2e086 drm/nouveau/disp/r535: initial support
date:   1 year, 1 month ago
:::::: branch date: 21 hours ago
:::::: commit date: 1 year, 1 month ago
config: i386-randconfig-053-20241120 (https://download.01.org/0day-ci/archive/20241129/202411290347.P7OA4EtQ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Julia Lawall <julia.lawall@inria.fr>
| Closes: https://lore.kernel.org/r/202411290347.P7OA4EtQ-lkp@intel.com/

cocci warnings: (new ones prefixed by >>)
>> drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c:667:42-46: ERROR: invalid reference to the index variable of the iterator on line 656

vim +667 drivers/gpu/drm/nouveau/nvkm/engine/disp/r535.c

9e99444490238d Ben Skeggs 2023-09-19  635  
9e99444490238d Ben Skeggs 2023-09-19  636  static struct nvkm_conn *
9e99444490238d Ben Skeggs 2023-09-19  637  r535_conn_new(struct nvkm_disp *disp, u32 id)
9e99444490238d Ben Skeggs 2023-09-19  638  {
9e99444490238d Ben Skeggs 2023-09-19  639  	NV0073_CTRL_SPECIFIC_GET_CONNECTOR_DATA_PARAMS *ctrl;
9e99444490238d Ben Skeggs 2023-09-19  640  	struct nvbios_connE dcbE = {};
9e99444490238d Ben Skeggs 2023-09-19  641  	struct nvkm_conn *conn;
9e99444490238d Ben Skeggs 2023-09-19  642  	int ret, index;
9e99444490238d Ben Skeggs 2023-09-19  643  
9e99444490238d Ben Skeggs 2023-09-19  644  	ctrl = nvkm_gsp_rm_ctrl_get(&disp->rm.objcom,
9e99444490238d Ben Skeggs 2023-09-19  645  				    NV0073_CTRL_CMD_SPECIFIC_GET_CONNECTOR_DATA, sizeof(*ctrl));
9e99444490238d Ben Skeggs 2023-09-19  646  	if (IS_ERR(ctrl))
9e99444490238d Ben Skeggs 2023-09-19  647  		return (void *)ctrl;
9e99444490238d Ben Skeggs 2023-09-19  648  
9e99444490238d Ben Skeggs 2023-09-19  649  	ctrl->subDeviceInstance = 0;
9e99444490238d Ben Skeggs 2023-09-19  650  	ctrl->displayId = BIT(id);
9e99444490238d Ben Skeggs 2023-09-19  651  
9e99444490238d Ben Skeggs 2023-09-19  652  	ctrl = nvkm_gsp_rm_ctrl_push(&disp->rm.objcom, ctrl, sizeof(*ctrl));
9e99444490238d Ben Skeggs 2023-09-19  653  	if (IS_ERR(ctrl))
9e99444490238d Ben Skeggs 2023-09-19  654  		return (void *)ctrl;
9e99444490238d Ben Skeggs 2023-09-19  655  
9e99444490238d Ben Skeggs 2023-09-19 @656  	list_for_each_entry(conn, &disp->conns, head) {
9e99444490238d Ben Skeggs 2023-09-19  657  		if (conn->index == ctrl->data[0].index) {
9e99444490238d Ben Skeggs 2023-09-19  658  			nvkm_gsp_rm_ctrl_done(&disp->rm.objcom, ctrl);
9e99444490238d Ben Skeggs 2023-09-19  659  			return conn;
9e99444490238d Ben Skeggs 2023-09-19  660  		}
9e99444490238d Ben Skeggs 2023-09-19  661  	}
9e99444490238d Ben Skeggs 2023-09-19  662  
9e99444490238d Ben Skeggs 2023-09-19  663  	dcbE.type = ctrl->data[0].type;
9e99444490238d Ben Skeggs 2023-09-19  664  	index = ctrl->data[0].index;
9e99444490238d Ben Skeggs 2023-09-19  665  	nvkm_gsp_rm_ctrl_done(&disp->rm.objcom, ctrl);
9e99444490238d Ben Skeggs 2023-09-19  666  
9e99444490238d Ben Skeggs 2023-09-19 @667  	ret = nvkm_conn_new(disp, index, &dcbE, &conn);
9e99444490238d Ben Skeggs 2023-09-19  668  	if (ret)
9e99444490238d Ben Skeggs 2023-09-19  669  		return ERR_PTR(ret);
9e99444490238d Ben Skeggs 2023-09-19  670  
9e99444490238d Ben Skeggs 2023-09-19  671  	list_add_tail(&conn->head, &disp->conns);
9e99444490238d Ben Skeggs 2023-09-19  672  	return conn;
9e99444490238d Ben Skeggs 2023-09-19  673  }
9e99444490238d Ben Skeggs 2023-09-19  674  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki