From: Florian Westphal <fw@strlen.de>
To: "Szőke Benjamin" <egyszeregy@freemail.hu>
Cc: Pablo Neira Ayuso <pablo@netfilter.org>,
Florian Westphal <fw@strlen.de>,
kadlec@netfilter.org, davem@davemloft.net, dsahern@kernel.org,
edumazet@google.com, kuba@kernel.org, pabeni@redhat.com,
horms@kernel.org, netfilter-devel@vger.kernel.org,
coreteam@netfilter.org, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org
Subject: Re: [PATCH] netfilter: uapi: Fix file names for case-insensitive filesystem.
Date: Fri, 29 Nov 2024 08:08:05 +0100 [thread overview]
Message-ID: <20241129070805.GA26153@breakpoint.cc> (raw)
In-Reply-To: <5f28d3d4-fa55-425c-9dd2-5616f5d4c0ac@freemail.hu>
Szőke Benjamin <egyszeregy@freemail.hu> wrote:
> and lower case *.h files can be merged to a common header files like
> "xt_dscp_common.h" but what about the *.c sources? For example if xt_DSCP.c
> removed and its content merged to xt_dscp.c before, what is the plan with
> kernel config options of CONFIG_NETFILTER_XT_TARGET_DSCP which was made for
> only xt_DSCP.c source to use in Makefile? Can we remove all of
> CONFIG_NETFILTER_XT_TARGET* config in the future which will lost their *.c
> source files?
Sure.
> obj-$(CONFIG_NETFILTER_XT_TARGET_DSCP) += xt_DSCP.o
> ...
This line goes away.
> obj-$(CONFIG_NETFILTER_XT_MATCH_DSCP) += xt_dscp.o
This line is changed to
obj-$(CONFIG_NETFILTER_XT_DSCP) += xt_dscp.o
Kconfig file NETFILTER_XT_TARGET/MATCH_DSCP are changed to
select new NETFILTER_XT_MATCH_DSCP.
This has been done before, see e.g.
28b949885f80 ("netfilter: xtables: merge xt_MARK into xt_mark")
you can follow this almost 1:1.
prev parent reply other threads:[~2024-11-29 7:08 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-11 16:36 [PATCH] netfilter: uapi: Fix file names for case-insensitive filesystem egyszeregy
2024-11-11 16:56 ` Florian Westphal
2024-11-11 18:34 ` Pablo Neira Ayuso
2024-11-11 20:18 ` Jan Engelhardt
2024-11-11 20:28 ` Szőke Benjamin
2024-11-11 21:16 ` Jan Engelhardt
2024-11-28 22:15 ` Bernd Petrovitsch
2024-11-29 7:08 ` Florian Westphal [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129070805.GA26153@breakpoint.cc \
--to=fw@strlen.de \
--cc=coreteam@netfilter.org \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=egyszeregy@freemail.hu \
--cc=horms@kernel.org \
--cc=kadlec@netfilter.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pablo@netfilter.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.