From: Christoph Hellwig <hch@lst.de>
To: "brookxu.cn" <brookxu.cn@gmail.com>
Cc: kbusch@kernel.org, axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
hare@suse.de, linux-nvme@lists.infradead.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v2 5/5] nvme-tcp: remove nvme_tcp_destroy_io_queues()
Date: Fri, 29 Nov 2024 09:12:43 +0100 [thread overview]
Message-ID: <20241129081243.GE6819@lst.de> (raw)
In-Reply-To: <9393a06d3fa651f9e68863b3cb9d952254f65e5a.1732699313.git.chunguang.xu@shopee.com>
On Wed, Nov 27, 2024 at 05:27:51PM +0800, brookxu.cn wrote:
> From: "Chunguang.xu" <chunguang.xu@shopee.com>
>
> Now when destroying the IO queue we call nvme_tcp_stop_io_queues() twice,
> nvme_tcp_destroy_io_queues() has an unnecessary call. Here we try to remove
> nvme_tcp_destroy_io_queues() and merge it into nvme_tcp_teardown_io_queues(),
> simplify the code and align with nvme-rdma, make it easy to maintaince.
Please split the reorganization from the fix.
Also can you add Fixes tag to the various bug fix patches?
prev parent reply other threads:[~2024-11-29 8:12 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 9:27 [PATCH v2 0/5] nvme: various bugs fix & code cleanup brookxu.cn
2024-11-27 9:27 ` [PATCH v2 1/5] nvme-tcp: fix the memleak while create new ctrl failed brookxu.cn
2024-11-29 8:10 ` Christoph Hellwig
2024-11-27 9:27 ` [PATCH v2 2/5] nvme-rdma: unquiesce admin_q before destroy it brookxu.cn
2024-11-29 8:11 ` Christoph Hellwig
2024-11-27 9:27 ` [PATCH v2 3/5] nvme-tcp: no need to quiesec admin_q in nvme_tcp_teardown_io_queues() brookxu.cn
2024-11-29 8:11 ` Christoph Hellwig
2024-11-27 9:27 ` [PATCH v2 4/5] nvme-tcp: simplify nvme_tcp_configure_admin_queue() brookxu.cn
2024-11-29 8:11 ` Christoph Hellwig
2024-11-27 9:27 ` [PATCH v2 5/5] nvme-tcp: remove nvme_tcp_destroy_io_queues() brookxu.cn
2024-11-29 8:12 ` Christoph Hellwig [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241129081243.GE6819@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=brookxu.cn@gmail.com \
--cc=hare@suse.de \
--cc=kbusch@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.