All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni via buildroot <buildroot@buildroot.org>
To: Julien Olivain <ju.o@free.fr>
Cc: buildroot@buildroot.org
Subject: Re: [Buildroot] [PATCH 1/1] support/testing: improve mosquitto test reliability
Date: Fri, 29 Nov 2024 08:57:33 +0100	[thread overview]
Message-ID: <20241129085733.757371c3@windsurf> (raw)
In-Reply-To: <18522091953e830b634abf3bbe776b17@free.fr>

Hello,

On Thu, 28 Nov 2024 21:35:49 +0100
Julien Olivain <ju.o@free.fr> wrote:

> > Thanks a lot, I've applied to master. However, I'm not a huge fan of
> > those hardcoded "sleep 5": it makes the test longer even on fast
> > machines, and it doesn't necessarily resolve the problem in all
> > situations. But I think you had yourself mentioned in some other thread
> > that it would be nicer to have some kind of retry loop instead?  
> 
> I am not a fan either...  This will help for the time being.

Absolutely, that's why I applied even though it isn't the "perfect"
solution.

> I have few patches about a retry loop I need polish before proposing.
> I also don't want to include retry logic everywhere like this one:
> https://gitlab.com/buildroot.org/buildroot/-/blob/2024.11-rc2/support/testing/tests/package/test_mdadm.py#L125
> 
> I currently add new functions in support/testing/infra/basetest.py for
> those situations.

Good idea!

Thomas
-- 
Thomas Petazzoni, co-owner and CEO, Bootlin
Embedded Linux and Kernel engineering and training
https://bootlin.com
_______________________________________________
buildroot mailing list
buildroot@buildroot.org
https://lists.buildroot.org/mailman/listinfo/buildroot

  reply	other threads:[~2024-11-29  7:57 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-11-26 18:28 [Buildroot] [PATCH 1/1] support/testing: improve mosquitto test reliability Julien Olivain
2024-11-28 20:18 ` Thomas Petazzoni via buildroot
2024-11-28 20:35   ` Julien Olivain
2024-11-29  7:57     ` Thomas Petazzoni via buildroot [this message]
2024-12-06  9:26 ` Peter Korsgaard

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241129085733.757371c3@windsurf \
    --to=buildroot@buildroot.org \
    --cc=ju.o@free.fr \
    --cc=thomas.petazzoni@bootlin.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.