From: Jakub Kicinski <kuba@kernel.org>
To: Jesse Van Gavere <jesseevg@gmail.com>
Cc: netdev@vger.kernel.org, woojung.huh@microchip.com,
UNGLinuxDriver@microchip.com, andrew@lunn.ch, olteanv@gmail.com,
Jesse Van Gavere <jesse.vangavere@scioteq.com>
Subject: Re: [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment to 32 bit boundaries
Date: Sat, 30 Nov 2024 14:06:59 -0800 [thread overview]
Message-ID: <20241130140659.4518f4a3@kernel.org> (raw)
In-Reply-To: <20241127221129.46155-1-jesse.vangavere@scioteq.com>
On Wed, 27 Nov 2024 23:11:29 +0100 Jesse Van Gavere wrote:
> Commit (SHA1: 8d7ae22ae9f8c8a4407f8e993df64440bdbd0cee) fixed this issue
> for the KSZ9477 by adjusting the regmap ranges.
The correct format for referring to other commits in Linux kernel is:
%h (\"%s\")
IOW:
Commit 8d7ae22ae9f8 ("net: dsa: microchip: KSZ9477 register regmap
alignment to 32 bit boundaries") fixed this issue...
> The same issue presents itself on the KSZ9896 regs and is fixed with
> the same regmap range modification.
Could you explain the impact? What will not work / break without this
change? Please add a Fixes tag indicating where buggy code was added
to make sure backporters know how far to backport.
--
pw-bot: cr
next prev parent reply other threads:[~2024-11-30 22:07 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 22:11 [PATCH] net: dsa: microchip: KSZ9896 register regmap alignment to 32 bit boundaries Jesse Van Gavere
2024-11-30 22:06 ` Jakub Kicinski [this message]
2024-12-03 5:29 ` Jesse Van Gavere
2024-12-06 22:12 ` Jesse Van Gavere
2024-12-07 1:24 ` Jakub Kicinski
2024-12-02 23:21 ` Tristram.Ha
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130140659.4518f4a3@kernel.org \
--to=kuba@kernel.org \
--cc=UNGLinuxDriver@microchip.com \
--cc=andrew@lunn.ch \
--cc=jesse.vangavere@scioteq.com \
--cc=jesseevg@gmail.com \
--cc=netdev@vger.kernel.org \
--cc=olteanv@gmail.com \
--cc=woojung.huh@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.