From: Jakub Kicinski <kuba@kernel.org>
To: David Wei <dw@davidwei.uk>
Cc: netdev@vger.kernel.org, Michael Chan <michael.chan@broadcom.com>,
Andy Gospodarek <andrew.gospodarek@broadcom.com>,
Somnath Kotur <somnath.kotur@broadcom.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>
Subject: Re: [PATCH net v2 3/3] bnxt_en: handle tpa_info in queue API implementation
Date: Sat, 30 Nov 2024 14:15:31 -0800 [thread overview]
Message-ID: <20241130141531.6fd449e1@kernel.org> (raw)
In-Reply-To: <20241127223855.3496785-4-dw@davidwei.uk>
On Wed, 27 Nov 2024 14:38:55 -0800 David Wei wrote:
> + if (bp->flags & BNXT_FLAG_TPA) {
> + rc = bnxt_alloc_one_tpa_info(bp, clone);
> + if (rc)
> + goto err_free_tpa_info;
> + }
> +
> bnxt_init_one_rx_ring_rxbd(bp, clone);
> bnxt_init_one_rx_agg_ring_rxbd(bp, clone);
>
> bnxt_alloc_one_rx_ring_skb(bp, clone, idx);
> if (bp->flags & BNXT_FLAG_AGG_RINGS)
> bnxt_alloc_one_rx_ring_page(bp, clone, idx);
> + if (bp->flags & BNXT_FLAG_TPA)
> + bnxt_alloc_one_tpa_info_data(bp, clone);
Could you explain the TPA related changes in the commit message?
Do we need to realloc the frags now since they don't come from
system memory?
next prev parent reply other threads:[~2024-11-30 22:15 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-27 22:38 [PATCH net v2 0/3] bnxt_en: support header page pool in queue API David Wei
2024-11-27 22:38 ` [PATCH net v2 1/3] bnxt_en: refactor tpa_info alloc/free into helpers David Wei
2024-11-27 22:38 ` [PATCH net v2 2/3] bnxt_en: refactor bnxt_alloc_rx_rings() to call bnxt_alloc_rx_agg_bmap() David Wei
2024-11-27 22:38 ` [PATCH net v2 3/3] bnxt_en: handle tpa_info in queue API implementation David Wei
2024-11-28 3:46 ` Somnath Kotur
2024-11-29 0:43 ` David Wei
2024-11-30 22:14 ` Jakub Kicinski
2024-11-30 22:52 ` David Wei
2024-11-30 22:15 ` Jakub Kicinski [this message]
2024-11-30 22:59 ` David Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241130141531.6fd449e1@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=andrew.gospodarek@broadcom.com \
--cc=davem@davemloft.net \
--cc=dw@davidwei.uk \
--cc=edumazet@google.com \
--cc=michael.chan@broadcom.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=somnath.kotur@broadcom.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.