From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, thomas@monjalon.net,
Tyler Retzlaff <roretzla@linux.microsoft.com>
Subject: Re: [RFC 1/3] eal: add enhanced lock annotations
Date: Mon, 2 Dec 2024 08:13:38 -0800 [thread overview]
Message-ID: <20241202081338.26ef799e@hermes.local> (raw)
In-Reply-To: <20241202125316.3732529-2-david.marchand@redhat.com>
On Mon, 2 Dec 2024 13:53:14 +0100
David Marchand <david.marchand@redhat.com> wrote:
> diff --git a/doc/api/doxy-api.conf.in b/doc/api/doxy-api.conf.in
> index d23352d300..ac490e7631 100644
> --- a/doc/api/doxy-api.conf.in
> +++ b/doc/api/doxy-api.conf.in
> @@ -103,6 +103,18 @@ PREDEFINED = __DOXYGEN__ \
> __rte_shared_trylock_function(x)= \
> __rte_assert_shared_lock(x)= \
> __rte_unlock_function(x)= \
> + __rte_capability(x)= \
> + __rte_requires_capability(x)= \
> + __rte_acquire_capability(x)= \
> + __rte_try_acquire_capability(x)= \
> + __rte_release_capability(x)= \
> + __rte_assert_capability(x)= \
> + __rte_requires_shared_capability(x)= \
> + __rte_acquire_shared_capability(x)= \
> + __rte_try_acquire_shared_capability(x)= \
> + __rte_release_shared_capability(x)= \
> + __rte_assert_shared_capability(x)= \
> + __rte_exclude_capability(x)= \
> __attribute__(x)=
I would suggest shortened names:
__rte_acquires(x)
__rte_releases(x)
__rte_must_hold(x)
Based on the original source of all these lock annotations which is sparse.
next prev parent reply other threads:[~2024-12-02 16:13 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-02 12:53 [RFC 0/3] Improve lock annotations David Marchand
2024-12-02 12:53 ` [RFC 1/3] eal: add enhanced " David Marchand
2024-12-02 16:13 ` Stephen Hemminger [this message]
2024-12-02 12:53 ` [RFC 2/3] eal: enhance lock annotations for spinlock and seqlock David Marchand
2024-12-05 6:18 ` Mattias Rönnblom
2024-12-02 12:53 ` [RFC 3/3] eal: enhance lock annotations for rwlock David Marchand
2024-12-12 16:00 ` [PATCH v2 0/3] Improve lock annotations David Marchand
2024-12-12 16:00 ` [PATCH v2 1/3] eal: add enhanced " David Marchand
2024-12-12 16:00 ` [PATCH v2 2/3] eal: enhance lock annotations for spinlock and seqlock David Marchand
2024-12-12 16:00 ` [PATCH v2 3/3] eal: enhance lock annotations for rwlock David Marchand
2024-12-13 10:47 ` [PATCH v2 0/3] Improve lock annotations David Marchand
2025-02-07 10:45 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241202081338.26ef799e@hermes.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=roretzla@linux.microsoft.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.