From: Greg KH <gregkh@linuxfoundation.org>
To: Ziwei Xiao <ziweixiao@google.com>
Cc: stable@vger.kernel.org, sashal@kernel.org,
pkaligineedi@google.com, hramamurthy@google.com
Subject: Re: [PATCH 5.15] gve: Fixes for napi_poll when budget is 0
Date: Mon, 2 Dec 2024 10:46:25 +0100 [thread overview]
Message-ID: <2024120216-gains-available-f94f@gregkh> (raw)
In-Reply-To: <20241126191922.2504882-1-ziweixiao@google.com>
On Tue, Nov 26, 2024 at 07:19:22PM +0000, Ziwei Xiao wrote:
> Netpoll will explicitly pass the polling call with a budget of 0 to
> indicate it's clearing the Tx path only. For the gve_rx_poll and
> gve_xdp_poll, they were mistakenly taking the 0 budget as the indication
> to do all the work. Add check to avoid the rx path and xdp path being
> called when budget is 0. And also avoid napi_complete_done being called
> when budget is 0 for netpoll.
>
> The original fix was merged here:
> https://lore.kernel.org/r/20231114004144.2022268-1-ziweixiao@google.com
> Resend it since the original one was not cleanly applied to 5.15 kernel.
>
> Fixes: f5cedc84a30d ("gve: Add transmit and receive support")
> Signed-off-by: Ziwei Xiao <ziweixiao@google.com>
> Reviewed-by: Praveen Kaligineedi <pkaligineedi@google.com>
> Signed-off-by: Praveen Kaligineedi <pkaligineedi@google.com>
> ---
No git id? :(
next prev parent reply other threads:[~2024-12-02 9:46 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-26 19:19 [PATCH 5.15] gve: Fixes for napi_poll when budget is 0 Ziwei Xiao
2024-11-26 19:56 ` Sasha Levin
2024-12-02 9:46 ` Greg KH [this message]
2024-12-09 18:46 ` Ziwei Xiao
2024-12-09 21:15 ` Greg KH
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024120216-gains-available-f94f@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=hramamurthy@google.com \
--cc=pkaligineedi@google.com \
--cc=sashal@kernel.org \
--cc=stable@vger.kernel.org \
--cc=ziweixiao@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.