From: kernel test robot <lkp@intel.com>
To: oe-kbuild@lists.linux.dev
Cc: lkp@intel.com, Dan Carpenter <error27@gmail.com>
Subject: drivers/scsi/qedi/qedi_main.c:924 qedi_get_boot_tgt_info() error: snprintf() chops off the last chars of 'block->target[index]->target_name.byte': 256 vs 255
Date: Tue, 3 Dec 2024 03:42:24 +0800 [thread overview]
Message-ID: <202412030334.S8d3ITeg-lkp@intel.com> (raw)
BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
CC: linux-kernel@vger.kernel.org
TO: Manish Rangankar <mrangankar@marvell.com>
CC: "Martin K. Petersen" <martin.petersen@oracle.com>
CC: Lee Duncan <lduncan@suse.com>
tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master
head: e70140ba0d2b1a30467d4af6bcfe761327b9ec95
commit: 2f1ea39870c95aa9fff6a0b48757625a0b22f551 scsi: qedi: Remove additional char from boot target iqnname
date: 4 years, 8 months ago
:::::: branch date: 20 hours ago
:::::: commit date: 4 years, 8 months ago
config: i386-randconfig-141-20241120 (https://download.01.org/0day-ci/archive/20241203/202412030334.S8d3ITeg-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412030334.S8d3ITeg-lkp@intel.com/
New smatch warnings:
drivers/scsi/qedi/qedi_main.c:924 qedi_get_boot_tgt_info() error: snprintf() chops off the last chars of 'block->target[index]->target_name.byte': 256 vs 255
Old smatch warnings:
drivers/scsi/qedi/qedi_main.c:956 qedi_find_boot_info() warn: returning -1 instead of -ENOMEM is sloppy
drivers/scsi/qedi/qedi_main.c:1607 qedi_alloc_global_queues() warn: missing error code 'status'
vim +924 drivers/scsi/qedi/qedi_main.c
ace7f46ba5fde7 Manish Rangankar 2016-12-01 915
534bbdf8832ae4 Manish Rangankar 2018-05-22 916 static void qedi_get_boot_tgt_info(struct nvm_iscsi_block *block,
534bbdf8832ae4 Manish Rangankar 2018-05-22 917 struct qedi_boot_target *tgt, u8 index)
534bbdf8832ae4 Manish Rangankar 2018-05-22 918 {
534bbdf8832ae4 Manish Rangankar 2018-05-22 919 u32 ipv6_en;
534bbdf8832ae4 Manish Rangankar 2018-05-22 920
534bbdf8832ae4 Manish Rangankar 2018-05-22 921 ipv6_en = !!(block->generic.ctrl_flags &
534bbdf8832ae4 Manish Rangankar 2018-05-22 922 NVM_ISCSI_CFG_GEN_IPV6_ENABLED);
534bbdf8832ae4 Manish Rangankar 2018-05-22 923
2f1ea39870c95a Manish Rangankar 2020-04-07 @924 snprintf(tgt->iscsi_name, sizeof(tgt->iscsi_name), "%s",
534bbdf8832ae4 Manish Rangankar 2018-05-22 925 block->target[index].target_name.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 926
534bbdf8832ae4 Manish Rangankar 2018-05-22 927 tgt->ipv6_en = ipv6_en;
534bbdf8832ae4 Manish Rangankar 2018-05-22 928
534bbdf8832ae4 Manish Rangankar 2018-05-22 929 if (ipv6_en)
534bbdf8832ae4 Manish Rangankar 2018-05-22 930 snprintf(tgt->ip_addr, IPV6_LEN, "%pI6\n",
534bbdf8832ae4 Manish Rangankar 2018-05-22 931 block->target[index].ipv6_addr.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 932 else
534bbdf8832ae4 Manish Rangankar 2018-05-22 933 snprintf(tgt->ip_addr, IPV4_LEN, "%pI4\n",
534bbdf8832ae4 Manish Rangankar 2018-05-22 934 block->target[index].ipv4_addr.byte);
534bbdf8832ae4 Manish Rangankar 2018-05-22 935 }
534bbdf8832ae4 Manish Rangankar 2018-05-22 936
--
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki
reply other threads:[~2024-12-02 19:45 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=202412030334.S8d3ITeg-lkp@intel.com \
--to=lkp@intel.com \
--cc=error27@gmail.com \
--cc=oe-kbuild@lists.linux.dev \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.