From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:6601:b0:1be9:327d:8ee3 with SMTP id h1csp3701411njk; Tue, 3 Dec 2024 05:59:46 -0800 (PST) X-Forwarded-Encrypted: i=2; AJvYcCXYhpeHX7Mec3kYYocOgHZUPhU78v7gbfrikY9TEYXKqjlmOlmt8161ZU9Sr0HtfeCL+qlexnlg29AL0A==@linaro.org X-Google-Smtp-Source: AGHT+IGAg7Ead8TPnqPMUfsJ4KZo9qV2xOTfChEBhkxZsQcyLXKzucZQ6ECeCq804YuAz3uGXNUR X-Received: by 2002:a05:6102:4421:b0:4af:400e:2a9c with SMTP id ada2fe7eead31-4af9733e158mr3170847137.25.1733234386005; Tue, 03 Dec 2024 05:59:46 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1733234385; cv=none; d=google.com; s=arc-20240605; b=KeyLsOYe066kZYbRsd/JIu6mGCI/0lN6yN9Y7n30pWZOeO7d7wnIZooQMN0znCTJHK b+xtU6LYYKG/+i/mVeoabDuA5be0WCc8uxmcdZEaCMwG4CcPo1PvqbrDXOXWDRDs7j76 gxIdNOfSnv+oQ74p85mpRqTWLmIfhncK4RbuJfTjiC/KI1pPcYGpx9jw8PQJw9J1gqnK mBBE692xRNw6BEHxFLCQDoxIowE1cNXgh6HbnXWWRvz/aYQUbffucaBGtJbc0m+9AbJR W7nIDbra4oBBzKTu6iOuLgyuYOG4V+TGpm2KYZ9++hh8Pr2Qxi2vUzK2iyKQ6QjgpP+D psUg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=sender:errors-to:list-subscribe:list-help:list-post:list-archive :list-unsubscribe:list-id:precedence:content-transfer-encoding :mime-version:references:in-reply-to:message-id:subject:cc:to:from :date:dkim-signature; bh=XrgDicMzggOvtH/s7ury3sPZkpoXQNZGJoOY2zieXNI=; fh=6D/6VQq5Q+Zja9Q7yYPz2cBlGUpAFsxG9UYP7RraElc=; b=J11YatHtVTz9+bLpmaog83zXb3zB2luh+0YCj5m1EpateixJzVAYpd6JiqvQidGt8v a9CeGWRW3ke2vAsvB7mXS8+eon/sZB0sA/Nq+X8skObizG+CAMRz1iTVafmAEfCwRJ3w ZyzKBAWLqgsXnTiFmVd7o1kc+UYNvzvybR5vPdAPeoVX3zfIzLSWfvB61CgrCV88lVwy YNDD4CafSy8LizywtXz3i61IjKI7UOLNppXbAJVWfbR4Gi5USpxRgpaoGtYZ8IE6EpSq ajhROxeEuoDrNER1lqlGGlE2dAicZoRwitYszssBLqHVhColQ+JjexbZyz8ZfsvmvJbw aM6w==; dara=google.com ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwjlDOVH; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Return-Path: Received: from lists.gnu.org (lists.gnu.org. [209.51.188.17]) by mx.google.com with ESMTPS id ada2fe7eead31-4af590d59a1si4969162137.20.2024.12.03.05.59.45 for (version=TLS1_2 cipher=ECDHE-ECDSA-CHACHA20-POLY1305 bits=256/256); Tue, 03 Dec 2024 05:59:45 -0800 (PST) Received-SPF: pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) client-ip=209.51.188.17; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=VwjlDOVH; spf=pass (google.com: domain of qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org designates 209.51.188.17 as permitted sender) smtp.mailfrom="qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Received: from localhost ([::1] helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1tITQw-0005h0-06; Tue, 03 Dec 2024 08:59:22 -0500 Received: from eggs.gnu.org ([2001:470:142:3::10]) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITQu-0005gY-Hv; Tue, 03 Dec 2024 08:59:20 -0500 Received: from dfw.source.kernel.org ([139.178.84.217]) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1tITQs-0003rQ-4w; Tue, 03 Dec 2024 08:59:20 -0500 Received: from smtp.kernel.org (transwarp.subspace.kernel.org [100.75.92.58]) by dfw.source.kernel.org (Postfix) with ESMTP id 7C9D65C5A62; Tue, 3 Dec 2024 13:58:31 +0000 (UTC) Received: by smtp.kernel.org (Postfix) with ESMTPSA id A45B7C4CECF; Tue, 3 Dec 2024 13:59:11 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733234354; bh=ybwMmLDPih2y8EAfYC3azst4Q0MnjEVlliaSDkdXsSs=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=VwjlDOVH1n7GGba7TRDsopIvkZvmZhHN4moFJ8pONrGP65YgmBbrAlLMXLT1jRsuf 5n2il0PqOsQw8KbrdZEOWXf9jVJkycCPzXiGa3NUvDtM3YKeCSXbWFxF9C0gK08VHD TCwXGR/3gd9GZcqBTTUv2RB0WayGtg92RbnvGBY0IfFM01PeTlY/DORc7SEnH8gY3Z KvZwIIT3c3Om1idwXQeRRxLga8wLtNdD2E7P8LMu8rYhNeWbMaq0wSILeNqrVvtFUH 9PM8PFeY5/HUOP1BbV694KCSPA5p3GR4R+9Njum62JEPVQ8jUmWJCP5V6SyQN8AvT7 s+vG4B/35zmIw== Date: Tue, 3 Dec 2024 14:59:08 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov Cc: Jonathan Cameron , Shiju Jose , Philippe =?UTF-8?B?TWF0aGlldS1EYXVkw6k=?= , Ani Sinha , Dongjiu Geng , Peter Maydell , Shannon Zhao , Yanan Wang , Zhao Liu , qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v2 0/5] Change ghes driver to use HEST-based offsets Message-ID: <20241203145908.06aee888@foz.lan> In-Reply-To: <20241203130310.0bde48c0@imammedo.users.ipa.redhat.com> References: <20241203130310.0bde48c0@imammedo.users.ipa.redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Received-SPF: pass client-ip=139.178.84.217; envelope-from=mchehab+huawei@kernel.org; helo=dfw.source.kernel.org X-Spam_score_int: -100 X-Spam_score: -10.1 X-Spam_bar: ---------- X-Spam_report: (-10.1 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-2.996, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_VALIDITY_CERTIFIED_BLOCKED=0.001, RCVD_IN_VALIDITY_RPBL_BLOCKED=0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-arm@nongnu.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org Sender: qemu-arm-bounces+alex.bennee=linaro.org@nongnu.org X-TUID: YvTgVrlNhnsp Em Tue, 3 Dec 2024 13:03:10 +0100 Igor Mammedov escreveu: > On Fri, 22 Nov 2024 14:14:10 +0100 > Mauro Carvalho Chehab wrote: > > > This series was part of the previous PR to add generic error injection > > support on GHES. It depends on a cleanup patch series sent earlier > > today: > > > > https://lore.kernel.org/qemu-devel/cover.1732266152.git.mchehab+huawei@kernel.org/T/#t > > > > It contains the changes of the math used to calculate offsets at HEST table > > and hardware_error firmware file. It prepares for the addition of GHES > > error injection. > > > > The first patch was previously at the cleanup series. It prepares > > the logic to support multiple sources. > > > > The second patch adds a new firmware file to store HEST address. > > > > The third patch use the new firmware to calculate offsets using > > HEST table. > > > > Patches 4 and 5 add migration support. They assume that this > > series will be merged for qemu 9.2 (maybe it is too late for that, > > as QEMU is now on soft freeze). > > > > I tested migration using both virt-9.1 and virt-9.2 machines > > on qemu 9.2. > > > > I also tested migration with: > > > > > qemu-9.1 -M virt-9.1 -cpu cortex-a57 => qemu-9.2 -M virt-9.1 -cpu cortex-a57 > > qemu-9.2 -M virt-9.1 -cpu cortex-a57 => qemu-9.1 -M virt-9.1 -cpu cortex-a57 > was that with HEST enabled (it's 'ras' machine option), > It would be better to provide full CLI used Yes. This is the full command line I'm using for virt-9.2 (urls sanitized): ~/qemu/build/qemu-system-aarch64 -m 4g,maxmem=8G,slots=8 -monitor stdio -no-reboot -bios ~/emulator/QEMU_EFI-silent.fd -kernel ~/kernel/arm64_build/arch/arm64/boot/Image.gz -device pcie-root-port,id=root_port1 -device virtio-blk-pci,drive=hd -device virtio-net-pci,netdev=mynet,id=bob -drive if=none,file=~/emulator/debian.qcow2,format=qcow2,id=hd -object memory-backend-ram,size=4G,id=mem0 -netdev type=user,id=mynet,hostfwd=tcp::5555-:22 -qmp tcp:localhost:4445,server=on,wait=off -M virt-9.2,nvdimm=on,gic-version=3,ras=on -cpu max -smp 4 -numa node,nodeid=0,cpus=0-3,memdev=mem0 -append 'earlycon nomodeset root=/dev/vda1 fsck.mode=skip tp_printk maxcpus=4' And this is for virt-9.1: ~/qemu/build/qemu-system-aarch64 -m 4g,maxmem=8G,slots=8 -monitor stdio -no-reboot -bios ~/emulator/QEMU_EFI-silent.fd -kernel ~/kernel/arm64_build/arch/arm64/boot/Image.gz -device pcie-root-port,id=root_port1 -device virtio-blk-pci,drive=hd -device virtio-net-pci,netdev=mynet,id=bob -drive if=none,file=~/emulator/debian.qcow2,format=qcow2,id=hd -object memory-backend-ram,size=4G,id=mem0 -netdev type=user,id=mynet,hostfwd=tcp::5555-:22 -qmp tcp:localhost:4445,server=on,wait=off -M virt-9.1,nvdimm=on,gic-version=3,ras=on -cpu max -smp 4 -numa node,nodeid=0,cpus=0-3,memdev=mem0 -append 'earlycon nomodeset root=/dev/vda1 fsck.mode=skip tp_printk maxcpus=4' I opted to use a shorter version just bolding the difference, as the above are a lot harder to see the differences. > > > > > --- > > > > v2: > > - some whitespace and comment changes > > - patch 3/6 (acpi/ghes: rename the function which gets hw error offsets) > > was merged on the cleanup series. > > > > Mauro Carvalho Chehab (5): > > acpi/ghes: Prepare to support multiple sources on ghes > > acpi/ghes: add a firmware file with HEST address > > acpi/ghes: Use HEST table offsets when preparing GHES records > > acpi/generic_event_device: Update GHES migration to cover hest addr > > acpi/generic_event_device: add logic to detect if HEST addr is > > available > > > > hw/acpi/generic_event_device.c | 30 +++++++ > > hw/acpi/ghes.c | 156 +++++++++++++++++++++++++++++---- > > hw/arm/virt-acpi-build.c | 33 ++++++- > > hw/core/machine.c | 2 + > > include/hw/acpi/ghes.h | 23 +++-- > > 5 files changed, 216 insertions(+), 28 deletions(-) > > > Thanks, Mauro