From: Jakub Kicinski <kuba@kernel.org>
To: Shinas Rasheed <srasheed@marvell.com>
Cc: <netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hgani@marvell.com>, <sedara@marvell.com>, <vimleshk@marvell.com>,
<thaller@redhat.com>, <wizhao@redhat.com>, <kheib@redhat.com>,
<egallen@redhat.com>, <konguyen@redhat.com>, <horms@kernel.org>,
<einstein.xue@synaxg.com>,
Veerasenareddy Burru <vburru@marvell.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Satananda Burla <sburla@marvell.com>,
Abhijit Ayarekar <aayarekar@marvell.com>
Subject: Re: [PATCH net v1 1/4] octeon_ep: fix race conditions in ndo_get_stats64
Date: Tue, 3 Dec 2024 18:23:03 -0800 [thread overview]
Message-ID: <20241203182303.0550b547@kernel.org> (raw)
In-Reply-To: <20241203072130.2316913-2-srasheed@marvell.com>
On Mon, 2 Dec 2024 23:21:27 -0800 Shinas Rasheed wrote:
> + clear_bit(OCTEP_DEV_STATE_OPEN, &oct->state);
> + /* Make sure device state open is cleared so that no more
> + * stats fetch can happen intermittently
> + */
> + smp_mb__after_atomic();
> + while (octep_drv_busy(oct))
> + msleep(20);
This is a poor re-implementation of a lock.
We have more lock types in Linux than I care to count now.
Please just use the right one. Hint, it's probably a spin lock or
RCU+synchronize_net() on close.
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-04 2:23 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 7:21 [PATCH net v1 0/4] Fix race conditions in ndo_get_stats64 Shinas Rasheed
2024-12-03 7:21 ` [PATCH net v1 1/4] octeon_ep: fix " Shinas Rasheed
2024-12-04 2:23 ` Jakub Kicinski [this message]
2024-12-03 7:21 ` [PATCH net v1 2/4] octeon_ep: remove firmware stats fetch " Shinas Rasheed
2024-12-03 7:21 ` [PATCH net v1 3/4] octeon_ep_vf: fix race conditions " Shinas Rasheed
2024-12-03 7:21 ` [PATCH net v1 4/4] octeon_ep_vf: remove firmware stats fetch " Shinas Rasheed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241203182303.0550b547@kernel.org \
--to=kuba@kernel.org \
--cc=aayarekar@marvell.com \
--cc=andrew+netdev@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=egallen@redhat.com \
--cc=einstein.xue@synaxg.com \
--cc=hgani@marvell.com \
--cc=horms@kernel.org \
--cc=kheib@redhat.com \
--cc=konguyen@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sburla@marvell.com \
--cc=sedara@marvell.com \
--cc=srasheed@marvell.com \
--cc=thaller@redhat.com \
--cc=vburru@marvell.com \
--cc=vimleshk@marvell.com \
--cc=wizhao@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.