All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Tobias Klauser <tklauser@distanz.ch>
Cc: linux-serial@vger.kernel.org, Jiri Slaby <jirislaby@kernel.org>
Subject: Re: [PATCH] serial: altera_jtaguart: Use DRV_NAME to initialize uart_driver.driver_name
Date: Tue, 3 Dec 2024 14:03:03 +0100	[thread overview]
Message-ID: <2024120337-unending-renewed-8e7e@gregkh> (raw)
In-Reply-To: <20241203125654.29657-1-tklauser@distanz.ch>

On Tue, Dec 03, 2024 at 01:56:54PM +0100, Tobias Klauser wrote:
> Use the DRV_NAME constant instead of the verbatim string.

Why?

> 
> Signed-off-by: Tobias Klauser <tklauser@distanz.ch>
> ---
>  drivers/tty/serial/altera_jtaguart.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/tty/serial/altera_jtaguart.c b/drivers/tty/serial/altera_jtaguart.c
> index b9c3c3bed0c1..9657c3bb8e66 100644
> --- a/drivers/tty/serial/altera_jtaguart.c
> +++ b/drivers/tty/serial/altera_jtaguart.c
> @@ -365,7 +365,7 @@ OF_EARLYCON_DECLARE(juart, "altr,juart-1.0", altera_jtaguart_earlycon_setup);
>  
>  static struct uart_driver altera_jtaguart_driver = {
>  	.owner		= THIS_MODULE,
> -	.driver_name	= "altera_jtaguart",
> +	.driver_name	= DRV_NAME,

Why don't we just use KBUILD_MODNAME here and get rid of DRV_NAME
entirely?

thanks,

greg k-h

  reply	other threads:[~2024-12-03 13:03 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-03 12:56 [PATCH] serial: altera_jtaguart: Use DRV_NAME to initialize uart_driver.driver_name Tobias Klauser
2024-12-03 13:03 ` Greg Kroah-Hartman [this message]
2024-12-03 13:14   ` Tobias Klauser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024120337-unending-renewed-8e7e@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=jirislaby@kernel.org \
    --cc=linux-serial@vger.kernel.org \
    --cc=tklauser@distanz.ch \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.