From: Greg KH <gregkh@linuxfoundation.org>
To: Xu Yang <xu.yang_2@nxp.com>
Cc: Thinh.Nguyen@synopsys.com, mathias.nyman@intel.com,
linux-usb@vger.kernel.org, imx@lists.linux.dev, jun.li@nxp.com
Subject: Re: [PATCH] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property
Date: Wed, 4 Dec 2024 15:56:30 +0100 [thread overview]
Message-ID: <2024120402-applause-perky-223c@gregkh> (raw)
In-Reply-To: <20241105073904.2416057-1-xu.yang_2@nxp.com>
On Tue, Nov 05, 2024 at 03:39:04PM +0800, Xu Yang wrote:
> The source of quirk XHCI_SKIP_PHY_INIT comes from xhci_plat_priv.quirks or
> software node property. This will set skip_phy_initialization if software
> node also has XHCI_SKIP_PHY_INIT property.
>
> Signed-off-by: Xu Yang <xu.yang_2@nxp.com>
> ---
> drivers/usb/host/xhci-plat.c | 3 ++-
> 1 file changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/usb/host/xhci-plat.c b/drivers/usb/host/xhci-plat.c
> index e6c9006bd568..77853b86794a 100644
> --- a/drivers/usb/host/xhci-plat.c
> +++ b/drivers/usb/host/xhci-plat.c
> @@ -290,7 +290,8 @@ int xhci_plat_probe(struct platform_device *pdev, struct device *sysdev, const s
>
> hcd->tpl_support = of_usb_host_tpl_support(sysdev->of_node);
>
> - if (priv && (priv->quirks & XHCI_SKIP_PHY_INIT))
> + if ((priv && (priv->quirks & XHCI_SKIP_PHY_INIT)) ||
> + (xhci->quirks & XHCI_SKIP_PHY_INIT))
Wrong indentation :(
Also, what commit id does this fix? Should it go to stable kernels, and
if so, how far back? And if not, why not?
thanks,
greg k-h
next prev parent reply other threads:[~2024-12-04 14:56 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-11-05 7:39 [PATCH] usb: host: xhci-plat: set skip_phy_initialization if software node has XHCI_SKIP_PHY_INIT property Xu Yang
2024-12-02 2:49 ` Xu Yang
2024-12-04 14:56 ` Greg KH [this message]
2024-12-09 10:36 ` Xu Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2024120402-applause-perky-223c@gregkh \
--to=gregkh@linuxfoundation.org \
--cc=Thinh.Nguyen@synopsys.com \
--cc=imx@lists.linux.dev \
--cc=jun.li@nxp.com \
--cc=linux-usb@vger.kernel.org \
--cc=mathias.nyman@intel.com \
--cc=xu.yang_2@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.