From: Jamin Lin via <qemu-devel@nongnu.org>
To: "Cédric Le Goater" <clg@kaod.org>,
"Peter Maydell" <peter.maydell@linaro.org>,
"Steven Lee" <steven_lee@aspeedtech.com>,
"Troy Lee" <leetroy@gmail.com>,
"Andrew Jeffery" <andrew@codeconstruct.com.au>,
"Joel Stanley" <joel@jms.id.au>,
"open list:ASPEED BMCs" <qemu-arm@nongnu.org>,
"open list:All patches CC here" <qemu-devel@nongnu.org>
Cc: <jamin_lin@aspeedtech.com>, <troy_lee@aspeedtech.com>,
<yunlin.tang@aspeedtech.com>
Subject: [PATCH v3 4/7] hw:sdhci: Directly set sd_spec_version instead of property
Date: Wed, 4 Dec 2024 16:05:20 +0800 [thread overview]
Message-ID: <20241204080523.4025780-5-jamin_lin@aspeedtech.com> (raw)
In-Reply-To: <20241204080523.4025780-1-jamin_lin@aspeedtech.com>
Directly set sd_spec_version instead of property and remove
unused local variable.
Signed-off-by: Jamin Lin <jamin_lin@aspeedtech.com>
---
hw/sd/aspeed_sdhci.c | 6 +-----
1 file changed, 1 insertion(+), 5 deletions(-)
diff --git a/hw/sd/aspeed_sdhci.c b/hw/sd/aspeed_sdhci.c
index ccaeefa75b..4e64e2537a 100644
--- a/hw/sd/aspeed_sdhci.c
+++ b/hw/sd/aspeed_sdhci.c
@@ -160,13 +160,9 @@ static void aspeed_sdhci_realize(DeviceState *dev, Error **errp)
sysbus_init_mmio(sbd, &sdhci->iomem);
for (int i = 0; i < sdhci->num_slots; ++i) {
- Object *sdhci_slot = OBJECT(&sdhci->slots[i]);
SysBusDevice *sbd_slot = SYS_BUS_DEVICE(&sdhci->slots[i]);
- if (!object_property_set_int(sdhci_slot, "sd-spec-version", 2, errp)) {
- return;
- }
-
+ sdhci->slots[i].sd_spec_version = 2;
sdhci->slots[i].capareg = asc->capareg;
if (!sysbus_realize(sbd_slot, errp)) {
--
2.34.1
next prev parent reply other threads:[~2024-12-04 8:07 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 8:05 [PATCH v3 0/7] Support SDHCI and eMMC for ast2700 Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:05 ` [PATCH v3 1/7] hw/sd/aspeed_sdhci: Fix coding style Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:13 ` Cédric Le Goater
2024-12-04 8:05 ` [PATCH v3 2/7] hw/arm/aspeed: " Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:14 ` Cédric Le Goater
2024-12-04 8:05 ` [PATCH v3 3/7] hw:sdhci: Introduce a new "capareg" class member to set the different Capability Registers Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:15 ` Cédric Le Goater
2024-12-04 8:35 ` Jamin Lin
2024-12-04 8:05 ` Jamin Lin via [this message]
2024-12-04 8:05 ` [PATCH v3 5/7] hw/sd/aspeed_sdhci: Add AST2700 Support Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:15 ` Cédric Le Goater
2024-12-04 8:05 ` [PATCH v3 6/7] aspeed/soc: Support SDHCI for AST2700 Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:20 ` Cédric Le Goater
2024-12-04 8:05 ` [PATCH v3 7/7] aspeed/soc: Support eMMC " Jamin Lin via
2024-12-04 8:05 ` Jamin Lin via
2024-12-04 8:21 ` Cédric Le Goater
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241204080523.4025780-5-jamin_lin@aspeedtech.com \
--to=qemu-devel@nongnu.org \
--cc=andrew@codeconstruct.com.au \
--cc=clg@kaod.org \
--cc=jamin_lin@aspeedtech.com \
--cc=joel@jms.id.au \
--cc=leetroy@gmail.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=steven_lee@aspeedtech.com \
--cc=troy_lee@aspeedtech.com \
--cc=yunlin.tang@aspeedtech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.