Re: [PATCH net] net: avoid potential UAF in default_operstate()

[Vladimir Oltean <vladimir.oltean@nxp.com>]

On Wed, Dec 04, 2024 at 12:46:11PM +0100, Eric Dumazet wrote:
> On Wed, Dec 4, 2024 at 12:41 PM Vladimir Oltean <vladimir.oltean@nxp.com> wrote:
> >
> > I meant: linkwatch runs periodically, via linkwatch_event(). Isn't there
> > a chance that linkwatch_event() can run once, immediately after
> > __rtnl_unlock() in netdev_run_todo(), while the netdev is in the
> > NETREG_UNREGISTERING state? Won't that create problems for __dev_get_by_index()
> > too? I guess it depends on when the netns is torn down, which I couldn't find.
> 
> I think lweventlist_lock and dev->link_watch_list are supposed to
> synchronize things.
> 
> linkwatch_sync_dev() only calls linkwatch_do_dev() if the device was
> atomically unlinked from lweventlist

No, I don't mean calls from linkwatch_sync_dev(). I mean other call
paths towards linkwatch_do_dev(), like for example linkwatch_fire_event() -
carrier down, whatever. Can't these be pending on an unregistering
net_device at the time we run __rtnl_unlock() in netdev_run_todo?
Otherwise, why would netdev_wait_allrefs_any() have a linkwatch_run_queue()
call just later?