Re: [PATCH 0/6] eliminate dependency on non-portable __SIZEOF_LONG__

[Stephen Hemminger <stephen@networkplumber.org>]

On Wed,  4 Dec 2024 12:09:49 -0800
Andre Muezerie <andremue@linux.microsoft.com> wrote:

> Macro __SIZEOF_LONG__ is not standardized and MSVC does not define it.
> Therefore the errors below are seen with MSVC:
> 
> ../lib/mldev/mldev_utils_scalar.c(465): error C2065:
>     '__SIZEOF_LONG__': undeclared identifier
> ../lib/mldev/mldev_utils_scalar.c(478): error C2051:
>     case expression not constant
> 
> ../lib/mldev/mldev_utils_scalar_bfloat16.c(33): error C2065:
>     '__SIZEOF_LONG__': undeclared identifier
> ../lib/mldev/mldev_utils_scalar_bfloat16.c(49): error C2051:
>     case expression not constant
> 
> Turns out that the places where __SIZEOF_LONG__ is currently
> being used can equaly well use sizeof(long) instead.
> 
> Andre Muezerie (6):
>   drivers/bus: eliminate dependency on non-portable __SIZEOF_LONG__
>   drivers/common: eliminate dependency on non-portable __SIZEOF_LONG__
>   drivers/dma: eliminate dependency on non-portable __SIZEOF_LONG__
>   drivers/net: eliminate dependency on non-portable __SIZEOF_LONG__
>   drivers/raw: eliminate dependency on non-portable __SIZEOF_LONG__
>   lib/mldev: eliminate dependency on non-portable __SIZEOF_LONG__
> 
>  drivers/bus/fslmc/mc/fsl_mc_cmd.h    | 2 +-
>  drivers/common/cnxk/roc_bits.h       | 4 ++--
>  drivers/common/nfp/nfp_platform.h    | 4 ++--
>  drivers/dma/dpaa/dpaa_qdma.h         | 2 +-
>  drivers/dma/hisilicon/hisi_dmadev.h  | 2 +-
>  drivers/net/ena/base/ena_plat_dpdk.h | 4 ++--
>  drivers/net/hns3/hns3_ethdev.h       | 2 +-
>  drivers/raw/ifpga/base/opae_osdep.h  | 4 ++--
>  lib/mldev/mldev_utils_scalar.h       | 2 +-
>  9 files changed, 13 insertions(+), 13 deletions(-)
> 
> --

BITS_PER_LONG etc should be in rte_common.h not scattered
all over these drivers.