From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id E62D12500CE; Wed, 4 Dec 2024 12:51:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733316692; cv=none; b=CUpzXQUI1Lajse+dt0yb6BqY5QP81sbbEWs55/ZIf8zi5pA6xvs5UgxvnUDjPHMW6+8bnJhsvpWoNNFf8WXdPc0eQ5sGZnxJIklEr5/b9D2VkGssqEIXk87FAddvs2tB6O2dHthFttJHvFd6GXmS+iKCOMZuhjyBBauAev1k9nU= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733316692; c=relaxed/simple; bh=GaOS2a2mtdazLC2Ljr7S+TzHBvqzFEWC0jbwRrqW0Lo=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=QnMVivkgOOyNdRI1SkiGTXcDDn5shf+V7MRIaErS8Ti7JOl6hOM3ZlLImy6hxLr/w/vZ61I0sJY6FKl7O/HxImlhdE/arHfSz9eQD/bcibZFgOUqezZEJ5ukGtM1VSHvx2H7FW9iHTk3l14xdFxrxm7yhm9SxwSneDAbt+UYIM4= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=Nmv9fl9b; arc=none smtp.client-ip=10.30.226.201 Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="Nmv9fl9b" Received: by smtp.kernel.org (Postfix) with ESMTPSA id 4FF99C4CED2; Wed, 4 Dec 2024 12:51:30 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733316691; bh=GaOS2a2mtdazLC2Ljr7S+TzHBvqzFEWC0jbwRrqW0Lo=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=Nmv9fl9bG8jv50qK+GwfNnq703ThaEBdH1IDJdDsmhR2AizCaEYR1xVajU79Abvoo eCJvW8uFAwJfGykGlqIgxX43+KLfVBlnlBbijxfGGDEws6p3DNSNnIUP8mQHeer0CT Gds/ZKyyZ9pFyZY5bi3UpFRS+P+AaEg3KFjmpF0hRXNaw2ya0Hr1GZgsNoS5WqvNIV 7a6D2FDNcGmXYYz1jCbOz7lxmdOQUu2UZqSoTzQfKJ9DFXAxlREnPV19uPo2+jccBo j3+cNniED9SjBkxa/taHv7YCSr0+WUdtK5DH3i+Ic+gW8KM0EyfxAOgxGdjpcM4mdu 4mOkm8gnJM3Mg== Date: Wed, 4 Dec 2024 13:51:27 +0100 From: Mauro Carvalho Chehab To: Hans Verkuil Cc: linux-kernel@vger.kernel.org, linux-media@vger.kernel.org, Ricardo Ribalda Subject: Re: [PATCH v4 5/5] docs: media: profile: make it clearer about maintainership duties Message-ID: <20241204135127.7b295c19@foz.lan> In-Reply-To: <57ed2ba7-ebe8-433f-bb52-914a020ca468@xs4all.nl> References: <57ed2ba7-ebe8-433f-bb52-914a020ca468@xs4all.nl> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-media@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit Em Wed, 4 Dec 2024 13:11:45 +0100 Hans Verkuil escreveu: > On 12/3/24 10:35, Mauro Carvalho Chehab wrote: > > During the review of the media committer's profile, it was noticed > > that the responsibility for timely review patches was not clear: > > such review is expected that all developers listed at MAINTAINERS > > with the "M:" tag (e.g. "maintainers" on its broad sense). > > > > This is orthogonal of being a media committer or not. Such duty > > is implied at: > > > > Documentation/admin-guide/reporting-issues.rst > > > > and at the MAINTAINERS header, when it says that even when the > > status is "odd fixes", the patches will flow in. > > > > So, let make it explicit at the maintainer-entry-profile that > > maintainers need to do timely reviews. > > > > Also, while right now our focus is on granting committer rights to > > maintainers, the media-committer model may evolve in the future to > > accept other committers that don't have such duties. > > > > So, make it clear at the media-committer.rst that the duties > > related to reviewing patches from others are for the drivers > > they are maintainers as well. > > > > Signed-off-by: Mauro Carvalho Chehab > > --- > > Documentation/driver-api/media/maintainer-entry-profile.rst | 5 +++++ > > Documentation/driver-api/media/media-committer.rst | 6 +++--- > > 2 files changed, 8 insertions(+), 3 deletions(-) > > > > diff --git a/Documentation/driver-api/media/maintainer-entry-profile.rst b/Documentation/driver-api/media/maintainer-entry-profile.rst > > index fa28059f7b3f..87b71f89b1df 100644 > > --- a/Documentation/driver-api/media/maintainer-entry-profile.rst > > +++ b/Documentation/driver-api/media/maintainer-entry-profile.rst > > @@ -173,6 +173,11 @@ b. Committers' workflow: patches are handled by media committers:: > > On both workflows, all patches shall be properly reviewed at > > linux-media@vger.kernel.org (LMML) before being merged at media-committers.git. > > > > +Such patches will be reviewed timely by the maintainers and reviewers as > > +listed in the MAINTAINERS file. The subsystem maintainers will follow one of > > +the above workflows, e. g. they will either send a pull request or merge > > +patches directly at the media-committers tree. > > + > > When patches are picked by patchwork and when merged at media-committers, > > CI bots will check for errors and may provide e-mail feedback about > > patch problems. When this happens, the patch submitter must fix them, or > > diff --git a/Documentation/driver-api/media/media-committer.rst b/Documentation/driver-api/media/media-committer.rst > > index 3d0987a8a93b..0bc038a0fdcc 100644 > > --- a/Documentation/driver-api/media/media-committer.rst > > +++ b/Documentation/driver-api/media/media-committer.rst > > @@ -90,9 +90,9 @@ be a part of their maintenance tasks. > > Due to that, to become a committer or a core committer, a consensus between > > all subsystem maintainers is required, as they all need to trust a developer > > well enough to be delegated the responsibility to maintain part of the code > > -and to properly review patches from third parties, in a timely manner and > > -keeping the status of the reviewed code at https://patchwork.linuxtv.org > > -updated. > > +and to properly review patches from third parties for the drivers that they > > +maintain in a timely manner and keeping the status of the patches at > > +https://patchwork.linuxtv.org updated. > > > > .. Note:: > > > > Looks OK to me, but I thought this was supposed to be folded into the 3/5 and 4/5 patches? I'll fold it once you and Ricardo gives the same review/Sob as marked on 3/5 and 4/5. Thanks, Mauro