Re: [RFC PATCH v3 1/2] mm: vmascan: add find_folios_written_back() helper

[kernel test robot <lkp@intel.com>]

Hi Chen,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build errors:

[auto build test ERROR on akpm-mm/mm-everything]

url:    https://github.com/intel-lab-lkp/linux/commits/Chen-Ridong/mm-vmascan-add-find_folios_written_back-helper/20241204-123817
base:   https://git.kernel.org/pub/scm/linux/kernel/git/akpm/mm.git mm-everything
patch link:    https://lore.kernel.org/r/20241204040158.2768519-2-chenridong%40huaweicloud.com
patch subject: [RFC PATCH v3 1/2] mm: vmascan: add find_folios_written_back() helper
config: i386-buildonly-randconfig-004 (https://download.01.org/0day-ci/archive/20241204/202412042108.Mu208bDJ-lkp@intel.com/config)
compiler: gcc-12 (Debian 12.2.0-14) 12.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241204/202412042108.Mu208bDJ-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412042108.Mu208bDJ-lkp@intel.com/

All errors (new ones prefixed by >>):

   In file included from include/linux/thread_info.h:27,
                    from include/linux/spinlock.h:60,
                    from include/linux/mmzone.h:8,
                    from include/linux/gfp.h:7,
                    from include/linux/mm.h:7,
                    from mm/vmscan.c:15:
   mm/vmscan.c: In function 'find_folios_written_back':
>> mm/vmscan.c:318:78: error: 'LRU_REFS_FLAGS' undeclared (first use in this function); did you mean 'LRU_REFS_MASK'?
     318 |                                 set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS,
         |                                                                              ^~~~~~~~~~~~~~
   include/linux/bitops.h:330:40: note: in definition of macro 'set_mask_bits'
     330 |         const typeof(*(ptr)) mask__ = (mask), bits__ = (bits);  \
         |                                        ^~~~
   mm/vmscan.c:318:78: note: each undeclared identifier is reported only once for each function it appears in
     318 |                                 set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS,
         |                                                                              ^~~~~~~~~~~~~~
   include/linux/bitops.h:330:40: note: in definition of macro 'set_mask_bits'
     330 |         const typeof(*(ptr)) mask__ = (mask), bits__ = (bits);  \
         |                                        ^~~~


vim +318 mm/vmscan.c

   285	
   286	/**
   287	 * find_folios_written_back - Find and move the written back folios to a new list.
   288	 * @list: filios list
   289	 * @clean: the written back folios list
   290	 * @skip: whether skip to move the written back folios to clean list.
   291	 */
   292	static inline void find_folios_written_back(struct list_head *list,
   293			struct list_head *clean, bool skip)
   294	{
   295		struct folio *folio;
   296		struct folio *next;
   297	
   298		list_for_each_entry_safe_reverse(folio, next, list, lru) {
   299			if (!folio_evictable(folio)) {
   300				list_del(&folio->lru);
   301				folio_putback_lru(folio);
   302				continue;
   303			}
   304	
   305			if (folio_test_reclaim(folio) &&
   306			    (folio_test_dirty(folio) || folio_test_writeback(folio))) {
   307				/* restore LRU_REFS_FLAGS cleared by isolate_folio() */
   308				if (lru_gen_enabled() && folio_test_workingset(folio))
   309					folio_set_referenced(folio);
   310				continue;
   311			}
   312	
   313			if (skip || folio_test_active(folio) || folio_test_referenced(folio) ||
   314			    folio_mapped(folio) || folio_test_locked(folio) ||
   315			    folio_test_dirty(folio) || folio_test_writeback(folio)) {
   316				/* don't add rejected folios to the oldest generation */
   317				if (lru_gen_enabled())
 > 318					set_mask_bits(&folio->flags, LRU_REFS_MASK | LRU_REFS_FLAGS,
   319						      BIT(PG_active));
   320				continue;
   321			}
   322	
   323			/* retry folios that may have missed folio_rotate_reclaimable() */
   324			list_move(&folio->lru, clean);
   325		}
   326	}
   327	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki