From mboxrd@z Thu Jan 1 00:00:00 1970 Received: by 2002:a17:504:d692:b0:1be9:327d:8ee3 with SMTP id na18csp770322njb; Thu, 5 Dec 2024 00:00:09 -0800 (PST) X-Forwarded-Encrypted: i=3; AJvYcCVZR1Q4u5j12XeU78Cg/jt9PWNpEtEpVQfVID4jEIT6vhBb6FVnqBqTU7mL0RWx9SRDJzHYgsiVbhgaLA==@linaro.org X-Google-Smtp-Source: AGHT+IG09Xlze49tzkniRIBT9vzaQyvmOjY8t6ihYCqslpMa+XRRu9nwEn0yGlHjQhUk/LPlFrhJ X-Received: by 2002:a05:620a:44d6:b0:7b6:701c:9e3 with SMTP id af79cd13be357-7b6a61c3fe3mr1184494285a.45.1733385608824; Thu, 05 Dec 2024 00:00:08 -0800 (PST) ARC-Seal: i=2; a=rsa-sha256; t=1733385608; cv=pass; d=google.com; s=arc-20240605; b=Kl7tY7W6JNClPAUB9uHdvU1bhPIFz+pVB1DEyxuV5jHzCPI/KUAUefnDSHYcDhgWii 6JGve13vFHynr7ZHY0FCtW6E5byRBGP5PMm5iOAQvR4n+PivzwfVeKWL5ZJJomniYzNL GE492EATgoW0QWo29ECeI/VzS/pyiUlAfOGKVJlNs8J8ZL3/cHkrlle8hPxSG+vUulT4 4zp/rqTMvlvPABONJBLHwGELW0PkvHA8nNg6J4ID9xCfsJCgvrgi8eRGbwKE3p8G2Bwr GoV/GDltDO4pl3kDcT51oDfWIpqxLqIIHwggdRd0+3jWbn62v34kdYtCTRBqiVD9bryt Bhiw== ARC-Message-Signature: i=2; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20240605; h=content-transfer-encoding:mime-version:list-unsubscribe :list-subscribe:list-id:precedence:references:in-reply-to:message-id :subject:cc:to:from:date:dkim-signature; bh=HqXvmhBigsRisuXDUexahntBLmvIJdwXX1sEsNn7x6Y=; fh=AJ8hn4ioKJA5lsG3NCMNx8yhntdFUmRi9f6dN5eYbeg=; b=X0Dwfj9t8v15WzTZuVrnwzYp12FFc4eJTTdoFWV3mD39ar7a7r+U7Vuz0K9F84AikC Ng6FuJSOkD2k9ImqJwY4gkZG5ScVbLuZdUy3txg/BGL4A+w1usZ8IokMhpf2uSrxM/nG f3l0PeH7UQp2TYAI6alZ9OWUE5r+2E1WUYKDZFuEzUNfoiJ4AEOVjlE9eHEdL3cbxBGe /NF1BUFbY/FXzd3DeVRtJTE3DSZVKjTMDHS/OsrDe9orFhoerYDF68pKn+QKG/C+pfxa F3ZnAJz6K3vyu3+AKcAMqbNjyHltKwJPxfUSIK5UdyHl2GNuIlCKdQFTIYF3iBuFIJ+O m+Pw==; dara=google.com ARC-Authentication-Results: i=2; mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jVlXlbqH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-432706-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-432706-alex.bennee=linaro.org@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Return-Path: Received: from ny.mirrors.kernel.org (ny.mirrors.kernel.org. [2604:1380:45d1:ec00::1]) by mx.google.com with ESMTPS id af79cd13be357-7b6b5a51915si105221185a.133.2024.12.05.00.00.08 for (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Thu, 05 Dec 2024 00:00:08 -0800 (PST) Received-SPF: pass (google.com: domain of linux-kernel+bounces-432706-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) client-ip=2604:1380:45d1:ec00::1; Authentication-Results: mx.google.com; dkim=pass header.i=@kernel.org header.s=k20201202 header.b=jVlXlbqH; arc=pass (i=1 dkim=pass dkdomain=kernel.org); spf=pass (google.com: domain of linux-kernel+bounces-432706-alex.bennee=linaro.org@vger.kernel.org designates 2604:1380:45d1:ec00::1 as permitted sender) smtp.mailfrom="linux-kernel+bounces-432706-alex.bennee=linaro.org@vger.kernel.org"; dmarc=pass (p=QUARANTINE sp=QUARANTINE dis=NONE) header.from=kernel.org Received: from smtp.subspace.kernel.org (relay.kernel.org [52.25.139.140]) (using TLSv1.2 with cipher ECDHE-ECDSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by ny.mirrors.kernel.org (Postfix) with ESMTPS id 3448516164C for ; Thu, 5 Dec 2024 08:00:06 +0000 (UTC) Received: from localhost.localdomain (localhost.localdomain [127.0.0.1]) by smtp.subspace.kernel.org (Postfix) with ESMTP id 5C3131C1F13; Thu, 5 Dec 2024 08:00:06 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b="jVlXlbqH" Received: from smtp.kernel.org (aws-us-west-2-korg-mail-1.web.codeaurora.org [10.30.226.201]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 18C121C3C15 for ; Thu, 5 Dec 2024 08:00:05 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=10.30.226.201 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733385606; cv=none; b=PozqLubbK8u5N9FDsoXDX/6AY8D/CLhrdgBTpmUICC6xaO4mXKIjIMjuOBRFwgjfvZVXHCqDa1gCGvQbJjqlfI32a6bNZBacrkUopwOJ+zK0WmIPFn16EfkaiiWQmp72epfjgn6Oyr5F0/r/Plv4WbMHZJz6O6bPMdm09qgACJI= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733385606; c=relaxed/simple; bh=q7ysq63iGMnUWGArTOv4L3H5qVOaDhKU0OUZpTni/Xg=; h=Date:From:To:Cc:Subject:Message-ID:In-Reply-To:References: MIME-Version:Content-Type; b=G4MXKmxMBtmDU/sk24eFpSLrwwOHx0Nb0laAmkHSIga6ICtQXQwYAUwOTw6mtO4mnO5Sj8/AlPxNuwYXIUqbmJBbFQm+8pUa6BgFoZDXyQnLsCFHj2zVs4I0eF87iNDvuUqhcR9EOFj0xXhBNZ/qZvnOjNQqyqrFwU4hUVDJ0HA= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=kernel.org header.i=@kernel.org header.b=jVlXlbqH; arc=none smtp.client-ip=10.30.226.201 Received: by smtp.kernel.org (Postfix) with ESMTPSA id 820FBC4CED1; Thu, 5 Dec 2024 08:00:03 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org; s=k20201202; t=1733385605; bh=q7ysq63iGMnUWGArTOv4L3H5qVOaDhKU0OUZpTni/Xg=; h=Date:From:To:Cc:Subject:In-Reply-To:References:From; b=jVlXlbqH6PR+Y396UgJAD97rcUiSCOmuBQtf1jEZvS3SAIn00BDsYr88FpVpPIZHt 7mmi0arZ61XfJVSxN9nPdsGuztCxaS9OvLcDEG0ddlTNxf50eNfexvTbBGrvG1QvmM lvi3rO2j0X3iCPj0+Gpbl9iz2wokXZcOD8rg3IL6Im0MgbJdbYgQ5m92RHGwBgNI+E TyJMqg/SlcodLQCcpUziYZB9cYaqNBltsr0SVpunycEDlchCIZLF0WddiMxKcFAV7+ oDB5Jmqm6mYDMq7odpIghOm31cR/8XBkh9bhdYXfKvD7/ftn43aQFS2gDNB5C8JJTG IuG6/oD8ktDjQ== Date: Thu, 5 Dec 2024 08:59:59 +0100 From: Mauro Carvalho Chehab To: Igor Mammedov Cc: Jonathan Cameron , Shiju Jose , "Michael S. Tsirkin" , Ani Sinha , Dongjiu Geng , linux-kernel@vger.kernel.org, qemu-arm@nongnu.org, qemu-devel@nongnu.org Subject: Re: [PATCH v5 13/16] acpi/ghes: better name the offset of the hardware error firmware Message-ID: <20241205085959.2223d079@foz.lan> In-Reply-To: <20241204173759.6f02561a@imammedo.users.ipa.redhat.com> References: <20b003136d8c008fd54e8d40c806f13867336e13.1733297707.git.mchehab+huawei@kernel.org> <20241204173759.6f02561a@imammedo.users.ipa.redhat.com> X-Mailer: Claws Mail 4.3.0 (GTK 3.24.43; x86_64-redhat-linux-gnu) Precedence: bulk X-Mailing-List: linux-kernel@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=US-ASCII Content-Transfer-Encoding: 7bit X-TUID: lXneXkXj3twr Em Wed, 4 Dec 2024 17:37:59 +0100 Igor Mammedov escreveu: > On Wed, 4 Dec 2024 08:41:21 +0100 > Mauro Carvalho Chehab wrote: > > > The hardware error firmware is where HEST error structures are > ^^^^^^^^^^^^^^^^^^^^^^^ I can't parse this, suspect you've meant something else here > > > stored. Those can be GHESv2, but they can also be other types. > > > > Better name the location of the hardware error. > > > > No functional changes. I meant this fw_cfg file: #define ACPI_HW_ERROR_FW_CFG_FILE "etc/hardware_errors" #define ACPI_HW_ERROR_ADDR_FW_CFG_FILE "etc/hardware_errors_addr" What about changing description to: The etc/hardware_errors fw_cfg file is where the HEST error source structures are stored. Those can be GHESv2, but they can also be other types. For more details about error source structure, see: https://uefi.org/specs/ACPI/6.5/18_Platform_Error_Interfaces.html#acpi-error-source Better name the address variable from ghes_error_le to hw_error_le to better reflect that. No functional changes. > > > > Signed-off-by: Mauro Carvalho Chehab > > Reviewed-by: Jonathan Cameron > > Reviewed-by: Igor Mammedov > > --- > > hw/acpi/generic_event_device.c | 4 ++-- > > hw/acpi/ghes.c | 4 ++-- > > include/hw/acpi/ghes.h | 2 +- > > 3 files changed, 5 insertions(+), 5 deletions(-) > > > > diff --git a/hw/acpi/generic_event_device.c b/hw/acpi/generic_event_device.c > > index 663d9cb09380..17baf36132a8 100644 > > --- a/hw/acpi/generic_event_device.c > > +++ b/hw/acpi/generic_event_device.c > > @@ -364,7 +364,7 @@ static const VMStateDescription vmstate_ghes = { > > .version_id = 1, > > .minimum_version_id = 1, > > .fields = (const VMStateField[]) { > > - VMSTATE_UINT64(ghes_addr_le, AcpiGhesState), > > + VMSTATE_UINT64(hw_error_le, AcpiGhesState), > > VMSTATE_END_OF_LIST() > > }, > > }; > > @@ -372,7 +372,7 @@ static const VMStateDescription vmstate_ghes = { > > static bool ghes_needed(void *opaque) > > { > > AcpiGedState *s = opaque; > > - return s->ghes_state.ghes_addr_le; > > + return s->ghes_state.hw_error_le; > > } > > > > static const VMStateDescription vmstate_ghes_state = { > > diff --git a/hw/acpi/ghes.c b/hw/acpi/ghes.c > > index 52c2b69d3664..90d76b9c2d8c 100644 > > --- a/hw/acpi/ghes.c > > +++ b/hw/acpi/ghes.c > > @@ -359,7 +359,7 @@ void acpi_ghes_add_fw_cfg(AcpiGhesState *ags, FWCfgState *s, > > > > /* Create a read-write fw_cfg file for Address */ > > fw_cfg_add_file_callback(s, ACPI_HW_ERROR_ADDR_FW_CFG_FILE, NULL, NULL, > > - NULL, &(ags->ghes_addr_le), sizeof(ags->ghes_addr_le), false); > > + NULL, &(ags->hw_error_le), sizeof(ags->hw_error_le), false); > > > > ags->present = true; > > } > > @@ -385,7 +385,7 @@ void ghes_record_cper_errors(const void *cper, size_t len, > > } > > ags = &acpi_ged_state->ghes_state; > > > > - start_addr = le64_to_cpu(ags->ghes_addr_le); > > + start_addr = le64_to_cpu(ags->hw_error_le); > > > > start_addr += source_id * sizeof(uint64_t); > > > > diff --git a/include/hw/acpi/ghes.h b/include/hw/acpi/ghes.h > > index 21666a4bcc8b..39619a2457cb 100644 > > --- a/include/hw/acpi/ghes.h > > +++ b/include/hw/acpi/ghes.h > > @@ -65,7 +65,7 @@ enum { > > }; > > > > typedef struct AcpiGhesState { > > - uint64_t ghes_addr_le; > > + uint64_t hw_error_le; > > bool present; /* True if GHES is present at all on this board */ > > } AcpiGhesState; > > > Thanks, Mauro