All of lore.kernel.org
 help / color / mirror / Atom feed
From: Petr Vorel <pvorel@suse.cz>
To: Martin Doucha <mdoucha@suse.cz>
Cc: ltp@lists.linux.it
Subject: Re: [LTP] [PATCH v3 1/2] nfs_lib.sh: Add support for extra NFS mount options
Date: Thu, 5 Dec 2024 11:34:39 +0100	[thread overview]
Message-ID: <20241205103439.GA28204@pevik> (raw)
In-Reply-To: <20241204172312.34099-1-mdoucha@suse.cz>

Hi Martin,

...
> +		nfs_opts="-o proto=$type,vers=$i"
> +
> +		if [ ! -z "$NFS_MOUNT_OPTS" ]; then

We have -n for non-null string. Even just [ "$NFS_MOUNT_OPTS" ] would work,
but -n is more obvious. I can change it before merge:

		if [ -n "$NFS_MOUNT_OPTS" ]; then

Reviewed-by: Petr Vorel <pvorel@suse.cz>

Kind regards,
Petr

> +			nfs_opts="$nfs_opts,$NFS_MOUNT_OPTS"
> +		fi
> +
>  		tst_res TINFO "Mounting $local_dir"
> -		nfs_mount "$local_dir" "$remote_dir" "-o proto=$type,vers=$i"
> +		nfs_mount "$local_dir" "$remote_dir" "$nfs_opts"

-- 
Mailing list info: https://lists.linux.it/listinfo/ltp

  parent reply	other threads:[~2024-12-05 10:35 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-04 17:23 [LTP] [PATCH v3 1/2] nfs_lib.sh: Add support for extra NFS mount options Martin Doucha
2024-12-04 17:23 ` [LTP] [PATCH v3 2/2] Add test for data integrity over NFS Martin Doucha
2024-12-05 11:10   ` Petr Vorel
2024-12-05 12:25     ` Martin Doucha
2024-12-06 14:52       ` Petr Vorel
2024-12-06  9:02   ` Petr Vorel
2024-12-05 10:34 ` Petr Vorel [this message]
2024-12-05 12:11   ` [LTP] [PATCH v3 1/2] nfs_lib.sh: Add support for extra NFS mount options Martin Doucha

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241205103439.GA28204@pevik \
    --to=pvorel@suse.cz \
    --cc=ltp@lists.linux.it \
    --cc=mdoucha@suse.cz \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.