From: Jakub Kicinski <kuba@kernel.org>
To: "Russell King (Oracle)" <linux@armlinux.org.uk>
Cc: Oleksij Rempel <o.rempel@pengutronix.de>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Paolo Abeni <pabeni@redhat.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Jonathan Corbet <corbet@lwn.net>,
kernel@pengutronix.de, linux-kernel@vger.kernel.org,
netdev@vger.kernel.org, Simon Horman <horms@kernel.org>,
Maxime Chevallier <maxime.chevallier@bootlin.com>,
linux-doc@vger.kernel.org
Subject: Re: [PATCH net-next v1 1/7] net: ethtool: plumb PHY stats to PHY drivers
Date: Thu, 5 Dec 2024 17:19:09 -0800 [thread overview]
Message-ID: <20241205171909.274715c2@kernel.org> (raw)
In-Reply-To: <Z1GVLf0RaYCP060b@shell.armlinux.org.uk>
On Thu, 5 Dec 2024 11:57:33 +0000 Russell King (Oracle) wrote:
> > + * The input structure is not zero-initialized and the implementation
> > + * must only set statistics which are actually collected by the device.
>
> Eh what? This states to me that the structure is not initialised, but
> drivers should not write to all members unless they support the
> statistic.
>
> Doesn't this mean we end up returning uninitialised data to userspace?
> If the structure is not initialised, how does core code know which
> statistics the driver has set to avoid returning uninitialised data?
It's not zero-initialized. Meaning it's initialized to a special magic
value that the core then checks for to decide if the driver actually
reported something.
Maybe this:
* Drivers must not zero out statistics which they don't report.
* Core will initialize members to ETHTOOL_STAT_NOT_SET and check
* for this value to report to user space only the stats actually
* supported by the device.
IDK how to phrase this better..
next prev parent reply other threads:[~2024-12-06 1:19 UTC|newest]
Thread overview: 30+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 7:56 [PATCH net-next v1 0/7] Introduce unified and structured PHY Oleksij Rempel
2024-12-03 7:56 ` [PATCH net-next v1 1/7] net: ethtool: plumb PHY stats to PHY drivers Oleksij Rempel
2024-12-03 8:30 ` Maxime Chevallier
2024-12-05 7:45 ` Mateusz Polchlopek
2024-12-05 11:57 ` Russell King (Oracle)
2024-12-06 1:19 ` Jakub Kicinski [this message]
2024-12-06 9:11 ` Russell King (Oracle)
2024-12-06 16:13 ` Jakub Kicinski
2024-12-10 12:03 ` Simon Horman
2024-12-03 7:56 ` [PATCH net-next v1 2/7] net: ethtool: add support for structured PHY statistics Oleksij Rempel
2024-12-05 12:00 ` Russell King (Oracle)
2024-12-03 7:56 ` [PATCH net-next v1 3/7] phy: replace bitwise flag definitions with BIT() macro Oleksij Rempel
2024-12-05 2:50 ` David Laight
2024-12-05 11:13 ` Oleksij Rempel
2024-12-05 12:02 ` Russell King (Oracle)
2024-12-05 12:06 ` Russell King (Oracle)
2024-12-03 7:56 ` [PATCH net-next v1 4/7] phy: introduce optional polling interface for PHY statistics Oleksij Rempel
2024-12-05 8:14 ` Mateusz Polchlopek
2024-12-05 12:09 ` Russell King (Oracle)
2024-12-06 11:14 ` Oleksij Rempel
2024-12-03 7:56 ` [PATCH net-next v1 5/7] ethtool: add helper to prevent invalid statistics exposure to userspace Oleksij Rempel
2024-12-05 8:45 ` Mateusz Polchlopek
2024-12-03 7:56 ` [PATCH net-next v1 6/7] phy: dp83td510: add statistics support Oleksij Rempel
2024-12-05 8:43 ` Mateusz Polchlopek
2024-12-05 9:01 ` Marc Kleine-Budde
2024-12-05 10:32 ` Mateusz Polchlopek
2024-12-05 10:58 ` Oleksij Rempel
2024-12-05 12:15 ` Russell King (Oracle)
2024-12-03 7:56 ` [PATCH net-next v1 7/7] phy: dp83tg720: " Oleksij Rempel
2024-12-05 11:48 ` [PATCH net-next v1 0/7] Introduce unified and structured PHY Russell King (Oracle)
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205171909.274715c2@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=corbet@lwn.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=horms@kernel.org \
--cc=kernel@pengutronix.de \
--cc=linux-doc@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=maxime.chevallier@bootlin.com \
--cc=netdev@vger.kernel.org \
--cc=o.rempel@pengutronix.de \
--cc=pabeni@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.