From: Jakub Kicinski <kuba@kernel.org>
To: Jijie Shao <shaojijie@huawei.com>
Cc: <davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<andrew+netdev@lunn.ch>, <horms@kernel.org>,
<shenjian15@huawei.com>, <wangpeiyang1@huawei.com>,
<liuyonglong@huawei.com>, <chenhao418@huawei.com>,
<sudongming1@huawei.com>, <xujunsheng@huawei.com>,
<shiyongbang@huawei.com>, <libaihan@huawei.com>,
<jonathan.cameron@huawei.com>,
<shameerali.kolothum.thodi@huawei.com>, <salil.mehta@huawei.com>,
<netdev@vger.kernel.org>, <linux-kernel@vger.kernel.org>,
<hkelam@marvell.com>
Subject: Re: [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset supported in this module
Date: Thu, 5 Dec 2024 17:59:16 -0800 [thread overview]
Message-ID: <20241205175916.07d50c71@kernel.org> (raw)
In-Reply-To: <20241203150131.3139399-7-shaojijie@huawei.com>
On Tue, 3 Dec 2024 23:01:30 +0800 Jijie Shao wrote:
> But the ethtool command already holds the rtnl lock in the dev_ethtool().
> So, the reset operation is not directly performed in
> ethtool_ops.reset() function. Instead, the reset operation
> is triggered by a scheduled task.
You can trivially factor out taking and releasing of the lock so that
ethtool path can execute just the logic inside, no?
next prev parent reply other threads:[~2024-12-06 1:59 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 15:01 [PATCH V4 RESEND net-next 0/7] Support some features for the HIBMCGE driver Jijie Shao
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 1/7] net: hibmcge: Add debugfs supported in this module Jijie Shao
2024-12-05 16:21 ` Simon Horman
2024-12-06 1:50 ` Jakub Kicinski
2024-12-06 2:28 ` Jijie Shao
2024-12-06 6:23 ` Greg Kroah-Hartman
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 2/7] net: hibmcge: Add irq_info file to debugfs Jijie Shao
2024-12-05 16:25 ` Simon Horman
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 3/7] net: hibmcge: Add unicast frame filter supported in this module Jijie Shao
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 4/7] net: hibmcge: Add register dump " Jijie Shao
2024-12-05 16:34 ` Simon Horman
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 5/7] net: hibmcge: Add pauseparam " Jijie Shao
2024-12-03 20:50 ` Andrew Lunn
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 6/7] net: hibmcge: Add reset " Jijie Shao
2024-12-05 16:33 ` Simon Horman
2024-12-06 1:59 ` Jakub Kicinski [this message]
2024-12-03 15:01 ` [PATCH V4 RESEND net-next 7/7] net: hibmcge: Add nway_reset " Jijie Shao
2024-12-03 20:52 ` Andrew Lunn
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241205175916.07d50c71@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=chenhao418@huawei.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=hkelam@marvell.com \
--cc=horms@kernel.org \
--cc=jonathan.cameron@huawei.com \
--cc=libaihan@huawei.com \
--cc=linux-kernel@vger.kernel.org \
--cc=liuyonglong@huawei.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=salil.mehta@huawei.com \
--cc=shameerali.kolothum.thodi@huawei.com \
--cc=shaojijie@huawei.com \
--cc=shenjian15@huawei.com \
--cc=shiyongbang@huawei.com \
--cc=sudongming1@huawei.com \
--cc=wangpeiyang1@huawei.com \
--cc=xujunsheng@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.