From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mgamail.intel.com (mgamail.intel.com [198.175.65.19]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 5D9EF1392 for ; Thu, 5 Dec 2024 13:17:38 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=198.175.65.19 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733404660; cv=none; b=Xe1IYpGsFZIWCXvIaG5dAkk259fC1Z2ueSVfmXfhtfWOieS0ktQsxRRzsAMXeKWK9Em7+b94JshGgz1fTusodwZBiicO4JH2O09t3ACBORSOziirtYvnj47QG7tMY3Qb6C0sAtHGk2p6zD/pfFKKfeO0nzNVhiPZsSgZb59pIsk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1733404660; c=relaxed/simple; bh=dtULcxZPBKgU5P5dEPOQgNjyBY9+xX/uFG5c4Q1rXpE=; h=Date:From:To:Cc:Subject:Message-ID:MIME-Version:Content-Type: Content-Disposition; b=LsAxHJ9cq61kvliuEiccazlHWm4CwTjDwGLE3w9X3vihDb3PTQ9OvJLiLz1L93btdKKKCLBd6LpUgxrmncZHxyySnTwcmwm68jE2wpOpUx8Yxw91ApTu3BbBWYvxWZEDkq15rdZg1kb3a8EcunwcnbL6CydOQNmjuL3jAgABL/U= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com; spf=pass smtp.mailfrom=intel.com; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b=JPWLUDnw; arc=none smtp.client-ip=198.175.65.19 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=intel.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=intel.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=intel.com header.i=@intel.com header.b="JPWLUDnw" DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=intel.com; i=@intel.com; q=dns/txt; s=Intel; t=1733404659; x=1764940659; h=date:from:to:cc:subject:message-id:mime-version; bh=dtULcxZPBKgU5P5dEPOQgNjyBY9+xX/uFG5c4Q1rXpE=; b=JPWLUDnwFM0wuuS3nSxsUDLBEylyJzTSoz3UMAIQiIAHT3IMFhB+0DpZ 5Yk7aFyt7onB6b9JMQ27i5GOgBV5cSRhYnfY/qDBx72oYHru1PoTJ4dIf BLBAuW1FfcGdO2b1ocLE19H/ujNRRtytLrdKbTpSYx+RWVbhL1v7bH2ao FUKa0xPuEmhvWYw9Snn2hx9kfbyxxXF0i8uPzMdALx34qjHZlow5rjqu1 T5c5QME+Uer9EaYnSL0Tpt/3GAoziEwvckxkEhvIjVUUuzoR05E/Yd8AZ KkzA9+a5Vi5noEQa+unqpGj0GhfjC54FHsgGDx0WymVk8E2dtI9cfjazM Q==; X-CSE-ConnectionGUID: 0tCS0en+SmGPfeXQyHywAA== X-CSE-MsgGUID: DW/ecw3CSJKBKZmf8HUd0Q== X-IronPort-AV: E=McAfee;i="6700,10204,11276"; a="33597699" X-IronPort-AV: E=Sophos;i="6.12,210,1728975600"; d="scan'208";a="33597699" Received: from orviesa003.jf.intel.com ([10.64.159.143]) by orvoesa111.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 05 Dec 2024 05:17:38 -0800 X-CSE-ConnectionGUID: ATy6Rid2R+6ox1KqbDRiWw== X-CSE-MsgGUID: P4LBRC/uQqGqG20lAw5b+Q== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="6.11,199,1725346800"; d="scan'208";a="99130494" Received: from lkp-server02.sh.intel.com (HELO 1f5a171d57e2) ([10.239.97.151]) by orviesa003.jf.intel.com with ESMTP; 05 Dec 2024 05:17:37 -0800 Received: from kbuild by 1f5a171d57e2 with local (Exim 4.96) (envelope-from ) id 1tJBjZ-0004DL-39; Thu, 05 Dec 2024 13:17:33 +0000 Date: Thu, 5 Dec 2024 21:17:26 +0800 From: kernel test robot To: oe-kbuild@lists.linux.dev Cc: lkp@intel.com, Dan Carpenter Subject: sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218) Message-ID: <202412052149.HYbkQDxc-lkp@intel.com> Precedence: bulk X-Mailing-List: oe-kbuild@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline BCC: lkp@intel.com CC: oe-kbuild-all@lists.linux.dev CC: linux-kernel@vger.kernel.org TO: Syed Saba Kareem CC: Mark Brown tree: https://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux.git master head: feffde684ac29a3b7aec82d2df850fbdbdee55e4 commit: d3534684ada99ef8c0899eb28c62b4462483ee19 ASoC: amd: acp: add Kconfig options for acp7.0 based platform driver date: 1 year, 1 month ago :::::: branch date: 2 days ago :::::: commit date: 1 year, 1 month ago config: x86_64-randconfig-161-20241205 (https://download.01.org/0day-ci/archive/20241205/202412052149.HYbkQDxc-lkp@intel.com/config) compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99) If you fix the issue in a separate patch/commit (i.e. not just a new version of the same patch/commit), kindly add following tags | Reported-by: kernel test robot | Reported-by: Dan Carpenter | Closes: https://lore.kernel.org/r/202412052149.HYbkQDxc-lkp@intel.com/ smatch warnings: sound/soc/amd/acp/acp70.c:217 acp70_pcm_resume() error: we previously assumed 'stream' could be null (see line 218) vim +/stream +217 sound/soc/amd/acp/acp70.c e84db124cb2158b Syed Saba Kareem 2023-10-21 207 e84db124cb2158b Syed Saba Kareem 2023-10-21 208 static int __maybe_unused acp70_pcm_resume(struct device *dev) e84db124cb2158b Syed Saba Kareem 2023-10-21 209 { e84db124cb2158b Syed Saba Kareem 2023-10-21 210 struct acp_dev_data *adata = dev_get_drvdata(dev); e84db124cb2158b Syed Saba Kareem 2023-10-21 211 struct acp_stream *stream; e84db124cb2158b Syed Saba Kareem 2023-10-21 212 struct snd_pcm_substream *substream; e84db124cb2158b Syed Saba Kareem 2023-10-21 213 snd_pcm_uframes_t buf_in_frames; e84db124cb2158b Syed Saba Kareem 2023-10-21 214 u64 buf_size; e84db124cb2158b Syed Saba Kareem 2023-10-21 215 e84db124cb2158b Syed Saba Kareem 2023-10-21 216 spin_lock(&adata->acp_lock); e84db124cb2158b Syed Saba Kareem 2023-10-21 @217 list_for_each_entry(stream, &adata->stream_list, list) { e84db124cb2158b Syed Saba Kareem 2023-10-21 @218 if (stream) { e84db124cb2158b Syed Saba Kareem 2023-10-21 219 substream = stream->substream; e84db124cb2158b Syed Saba Kareem 2023-10-21 220 if (substream && substream->runtime) { e84db124cb2158b Syed Saba Kareem 2023-10-21 221 buf_in_frames = (substream->runtime->buffer_size); e84db124cb2158b Syed Saba Kareem 2023-10-21 222 buf_size = frames_to_bytes(substream->runtime, buf_in_frames); e84db124cb2158b Syed Saba Kareem 2023-10-21 223 config_pte_for_stream(adata, stream); e84db124cb2158b Syed Saba Kareem 2023-10-21 224 config_acp_dma(adata, stream, buf_size); e84db124cb2158b Syed Saba Kareem 2023-10-21 225 if (stream->dai_id) e84db124cb2158b Syed Saba Kareem 2023-10-21 226 restore_acp_i2s_params(substream, adata, stream); e84db124cb2158b Syed Saba Kareem 2023-10-21 227 else e84db124cb2158b Syed Saba Kareem 2023-10-21 228 restore_acp_pdm_params(substream, adata); e84db124cb2158b Syed Saba Kareem 2023-10-21 229 } e84db124cb2158b Syed Saba Kareem 2023-10-21 230 } e84db124cb2158b Syed Saba Kareem 2023-10-21 231 } e84db124cb2158b Syed Saba Kareem 2023-10-21 232 spin_unlock(&adata->acp_lock); e84db124cb2158b Syed Saba Kareem 2023-10-21 233 return 0; e84db124cb2158b Syed Saba Kareem 2023-10-21 234 } e84db124cb2158b Syed Saba Kareem 2023-10-21 235 :::::: The code at line 217 was first introduced by commit :::::: e84db124cb2158b538820f31f641c28b86fb3ca3 ASoC: amd: acp: Add pci legacy driver support for acp7.0 platform :::::: TO: Syed Saba Kareem :::::: CC: Mark Brown -- 0-DAY CI Kernel Test Service https://github.com/intel/lkp-tests/wiki