Re: [PATCH RFC 2/2] mailbox: tmelite-qmp: Introduce QCOM TMEL QMP mailbox driver

[kernel test robot <lkp@intel.com>]

Hi Sricharan,

[This is a private test report for your RFC patch.]
kernel test robot noticed the following build warnings:

[auto build test WARNING on v6.12]
[cannot apply to robh/for-next linus/master v6.13-rc1 next-20241205]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Sricharan-R/dt-bindings-mailbox-qcom-Document-qcom-tmelite-qmp/20241205-161122
base:   v6.12
patch link:    https://lore.kernel.org/r/20241205080633.2623142-3-quic_srichara%40quicinc.com
patch subject: [PATCH RFC 2/2] mailbox: tmelite-qmp: Introduce QCOM TMEL QMP mailbox driver
config: sh-allmodconfig (https://download.01.org/0day-ci/archive/20241205/202412052339.XMsRYjf4-lkp@intel.com/config)
compiler: sh4-linux-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241205/202412052339.XMsRYjf4-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412052339.XMsRYjf4-lkp@intel.com/

All warnings (new ones prefixed by >>):

   In file included from include/linux/device.h:15,
                    from include/linux/dma-mapping.h:8,
                    from drivers/mailbox/qcom-tmelite-qmp.c:10:
   drivers/mailbox/qcom-tmelite-qmp.c: In function 'qmp_send_data':
>> drivers/mailbox/qcom-tmelite-qmp.c:303:36: warning: format '%lu' expects argument of type 'long unsigned int', but argument 3 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
     303 |                 dev_err(mdev->dev, "Unsupported packet size %lu\n", pkt->iov_len);
         |                                    ^~~~~~~~~~~~~~~~~~~~~~~~~~~~~~~
   include/linux/dev_printk.h:110:30: note: in definition of macro 'dev_printk_index_wrap'
     110 |                 _p_func(dev, fmt, ##__VA_ARGS__);                       \
         |                              ^~~
   include/linux/dev_printk.h:154:56: note: in expansion of macro 'dev_fmt'
     154 |         dev_printk_index_wrap(_dev_err, KERN_ERR, dev, dev_fmt(fmt), ##__VA_ARGS__)
         |                                                        ^~~~~~~
   drivers/mailbox/qcom-tmelite-qmp.c:303:17: note: in expansion of macro 'dev_err'
     303 |                 dev_err(mdev->dev, "Unsupported packet size %lu\n", pkt->iov_len);
         |                 ^~~~~~~
   drivers/mailbox/qcom-tmelite-qmp.c:303:63: note: format string is defined here
     303 |                 dev_err(mdev->dev, "Unsupported packet size %lu\n", pkt->iov_len);
         |                                                             ~~^
         |                                                               |
         |                                                               long unsigned int
         |                                                             %u
   In file included from include/asm-generic/bug.h:22,
                    from arch/sh/include/asm/bug.h:112,
                    from include/linux/bug.h:5,
                    from include/linux/thread_info.h:13,
                    from include/asm-generic/preempt.h:5,
                    from ./arch/sh/include/generated/asm/preempt.h:1,
                    from include/linux/preempt.h:79,
                    from include/linux/spinlock.h:56,
                    from include/linux/swait.h:7,
                    from include/linux/completion.h:12,
                    from drivers/mailbox/qcom-tmelite-qmp.c:7:
   drivers/mailbox/qcom-tmelite-qmp.c: In function 'tmelcom_process_request':
>> include/linux/kern_levels.h:5:25: warning: format '%lu' expects argument of type 'long unsigned int', but argument 2 has type 'size_t' {aka 'unsigned int'} [-Wformat=]
       5 | #define KERN_SOH        "\001"          /* ASCII Start Of Header */
         |                         ^~~~~~
   include/linux/printk.h:462:25: note: in definition of macro 'printk_index_wrap'
     462 |                 _p_func(_fmt, ##__VA_ARGS__);                           \
         |                         ^~~~
   include/linux/printk.h:533:9: note: in expansion of macro 'printk'
     533 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |         ^~~~~~
   include/linux/kern_levels.h:11:25: note: in expansion of macro 'KERN_SOH'
      11 | #define KERN_ERR        KERN_SOH "3"    /* error conditions */
         |                         ^~~~~~~~
   include/linux/printk.h:533:16: note: in expansion of macro 'KERN_ERR'
     533 |         printk(KERN_ERR pr_fmt(fmt), ##__VA_ARGS__)
         |                ^~~~~~~~
   drivers/mailbox/qcom-tmelite-qmp.c:704:17: note: in expansion of macro 'pr_err'
     704 |                 pr_err("Invalid pkt.size received size: %lu, expected: %zu\n",
         |                 ^~~~~~


vim +303 drivers/mailbox/qcom-tmelite-qmp.c

   281	
   282	/**
   283	 * qmp_send_data() - Copy the data to the channel's mailbox and notify
   284	 *		     remote subsystem of new data. This function will
   285	 *		     return an error if the previous message sent has
   286	 *		     not been read. Cannot Sleep.
   287	 * @chan:	mailbox channel that data is to be sent over.
   288	 * @data:	Data to be sent to remote processor, should be in the format of
   289	 *		a kvec.
   290	 *
   291	 * Return: 0 on succes or standard Linux error code.
   292	 */
   293	static int qmp_send_data(struct qmp_device *mdev, void *data)
   294	{
   295		struct kvec *pkt = (struct kvec *)data;
   296		void __iomem *addr;
   297		unsigned long flags;
   298	
   299		if (!mdev || !data || !completion_done(&mdev->ch_complete))
   300			return -EINVAL;
   301	
   302		if (pkt->iov_len > QMP_MAX_PKT_SIZE) {
 > 303			dev_err(mdev->dev, "Unsupported packet size %lu\n", pkt->iov_len);
   304			return -EINVAL;
   305		}
   306	
   307		spin_lock_irqsave(&mdev->tx_lock, flags);
   308		if (mdev->tx_sent) {
   309			spin_unlock_irqrestore(&mdev->tx_lock, flags);
   310			return -EAGAIN;
   311		}
   312	
   313		dev_dbg(mdev->dev, "%s: mcore 0x%x ucore 0x%x", __func__,
   314			mdev->mcore.val, mdev->ucore.val);
   315	
   316		addr = mdev->mcore_desc + QMP_CTRL_DATA_SIZE;
   317		memcpy_toio(addr, pkt->iov_base, pkt->iov_len);
   318	
   319		mdev->mcore.bits.frag_size = pkt->iov_len;
   320		mdev->mcore.bits.rem_frag_count = 0;
   321	
   322		dev_dbg(mdev->dev, "Copied buffer to mbox, sz: %d",
   323			mdev->mcore.bits.frag_size);
   324	
   325		mdev->tx_sent = true;
   326		QMP_MCORE_CH_VAR_TOGGLE(mdev, tx);
   327		send_irq(mdev);
   328		qmp_schedule_tx_timeout(mdev);
   329		spin_unlock_irqrestore(&mdev->tx_lock, flags);
   330	
   331		return 0;
   332	}
   333	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki