From: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
To: jbrunet@baylibre.com, linux-hwmon@vger.kernel.org
Cc: jdelvare@suse.com, linux@roeck-us.net,
linux-kernel@vger.kernel.org,
Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
Subject: [PATCH hwmon-next] hwmon: (pmbus/tps25990) Remove unnecessary call
Date: Fri, 6 Dec 2024 11:58:39 +0530 [thread overview]
Message-ID: <20241206062839.313292-1-dheeraj.linuxdev@gmail.com> (raw)
This commit addresses a structurally dead code issue detected by
Coverity (CID 1602227). An integer is returned early in one of the
switch cases causing the later statements to never be called. The
return statement is removed following convention in the other switch
cases.
Signed-off-by: Dheeraj Reddy Jonnalagadda <dheeraj.linuxdev@gmail.com>
---
drivers/hwmon/pmbus/tps25990.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/hwmon/pmbus/tps25990.c b/drivers/hwmon/pmbus/tps25990.c
index cc0f5c7cecb0..0d2655e69549 100644
--- a/drivers/hwmon/pmbus/tps25990.c
+++ b/drivers/hwmon/pmbus/tps25990.c
@@ -130,7 +130,6 @@ static int tps25990_read_word_data(struct i2c_client *client,
break;
case PMBUS_VIRT_READ_IIN_MAX:
- return TPS25990_READ_IIN_PEAK;
ret = pmbus_read_word_data(client, page, phase,
TPS25990_READ_IIN_PEAK);
break;
--
2.34.1
next reply other threads:[~2024-12-06 6:28 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 6:28 Dheeraj Reddy Jonnalagadda [this message]
2024-12-06 7:57 ` [PATCH hwmon-next] hwmon: (pmbus/tps25990) Remove unnecessary call Guenter Roeck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206062839.313292-1-dheeraj.linuxdev@gmail.com \
--to=dheeraj.linuxdev@gmail.com \
--cc=jbrunet@baylibre.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.