From: Jakub Kicinski <kuba@kernel.org>
To: Alexander Lobakin <aleksander.lobakin@intel.com>
Cc: "Alexei Starovoitov" <ast@kernel.org>,
"Daniel Borkmann" <daniel@iogearbox.net>,
"John Fastabend" <john.fastabend@gmail.com>,
"Andrii Nakryiko" <andrii@kernel.org>,
"David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Toke Høiland-Jørgensen" <toke@redhat.com>,
"Maciej Fijalkowski" <maciej.fijalkowski@intel.com>,
"Stanislav Fomichev" <sdf@fomichev.me>,
"Magnus Karlsson" <magnus.karlsson@intel.com>,
nex.sw.ncis.osdt.itp.upstreaming@intel.com, bpf@vger.kernel.org,
netdev@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH net-next v6 09/10] page_pool: allow mixing PPs within one bulk
Date: Fri, 6 Dec 2024 08:20:58 -0800 [thread overview]
Message-ID: <20241206082058.4a185982@kernel.org> (raw)
In-Reply-To: <f817137c-3f02-4c12-96ef-04b7dcf5501a@intel.com>
On Fri, 6 Dec 2024 14:49:18 +0100 Alexander Lobakin wrote:
> > nit: netmem_pp is not a great name. Ain't nothing especially netmem
> > about it, it's just the _current_ page pool.
>
> It's the page_pool of the @netmem we're processing on this iteration.
> "This netmem's PP" => netmem_pp.
> Current page_pool which we'll use for recycling is @pool.
Heh, yes, I guess there are levels to current..ness :)
Maybe instead of current the one we're servicing could be called tgt_pp
and the one from iterator just pp? No big deal either way, tho, this is
very nit picky and subjective...
next prev parent reply other threads:[~2024-12-06 16:21 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-03 17:37 [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 01/10] xsk: align &xdp_buff_xsk harder Alexander Lobakin
2024-12-04 10:27 ` Toke Høiland-Jørgensen
2024-12-03 17:37 ` [PATCH net-next v6 02/10] bpf, xdp: constify some bpf_prog * function arguments Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 03/10] xdp, xsk: constify read-only arguments of some static inline helpers Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 04/10] xdp: allow attaching already registered memory model to xdp_rxq_info Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 05/10] xsk: allow attaching XSk pool via xdp_rxq_info_reg_mem_model() Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 06/10] xdp: register system page pool as an XDP memory model Alexander Lobakin
2024-12-03 17:37 ` [PATCH net-next v6 07/10] netmem: add a couple of page helper wrappers Alexander Lobakin
2024-12-04 10:49 ` Toke Høiland-Jørgensen
2024-12-06 4:03 ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 08/10] page_pool: make page_pool_put_page_bulk() handle array of netmems Alexander Lobakin
2024-12-04 10:50 ` Toke Høiland-Jørgensen
2024-12-06 4:07 ` Mina Almasry
2024-12-03 17:37 ` [PATCH net-next v6 09/10] page_pool: allow mixing PPs within one bulk Alexander Lobakin
2024-12-06 2:40 ` Jakub Kicinski
2024-12-06 13:49 ` Alexander Lobakin
2024-12-06 16:20 ` Jakub Kicinski [this message]
2024-12-03 17:37 ` [PATCH net-next v6 10/10] xdp: get rid of xdp_frame::mem.id Alexander Lobakin
2024-12-06 7:10 ` [PATCH net-next v6 00/10] xdp: a fistful of generic changes pt. I patchwork-bot+netdevbpf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206082058.4a185982@kernel.org \
--to=kuba@kernel.org \
--cc=aleksander.lobakin@intel.com \
--cc=andrii@kernel.org \
--cc=ast@kernel.org \
--cc=bpf@vger.kernel.org \
--cc=daniel@iogearbox.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=john.fastabend@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maciej.fijalkowski@intel.com \
--cc=magnus.karlsson@intel.com \
--cc=netdev@vger.kernel.org \
--cc=nex.sw.ncis.osdt.itp.upstreaming@intel.com \
--cc=pabeni@redhat.com \
--cc=sdf@fomichev.me \
--cc=toke@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.