Re: [PATCHv11 07/10] block: expose write streams for block device nodes

[kernel test robot <lkp@intel.com>]

Hi Keith,

kernel test robot noticed the following build errors:

[auto build test ERROR on axboe-block/for-next]
[also build test ERROR on next-20241205]
[cannot apply to brauner-vfs/vfs.all hch-configfs/for-next linus/master v6.13-rc1]
[If your patch is applied to the wrong git tree, kindly drop us a note.
And when submitting patch, we suggest to use '--base' as documented in
https://git-scm.com/docs/git-format-patch#_base_tree_information]

url:    https://github.com/intel-lab-lkp/linux/commits/Keith-Busch/fs-add-a-write-stream-field-to-the-kiocb/20241206-095707
base:   https://git.kernel.org/pub/scm/linux/kernel/git/axboe/linux-block.git for-next
patch link:    https://lore.kernel.org/r/20241206015308.3342386-8-kbusch%40meta.com
patch subject: [PATCHv11 07/10] block: expose write streams for block device nodes
config: arm-am200epdkit_defconfig (https://download.01.org/0day-ci/archive/20241206/202412061104.fZI8AFNH-lkp@intel.com/config)
compiler: arm-linux-gnueabi-gcc (GCC) 14.2.0
reproduce (this is a W=1 build): (https://download.01.org/0day-ci/archive/20241206/202412061104.fZI8AFNH-lkp@intel.com/reproduce)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Closes: https://lore.kernel.org/oe-kbuild-all/202412061104.fZI8AFNH-lkp@intel.com/

All errors (new ones prefixed by >>):

   block/bdev.c: In function 'bdev_statx':
>> block/bdev.c:1299:29: error: 'STATX_WRITE_STREAM' undeclared (first use in this function); did you mean 'STATX_WRITE_ATOMIC'?
    1299 |         if ((request_mask & STATX_WRITE_STREAM) &&
         |                             ^~~~~~~~~~~~~~~~~~
         |                             STATX_WRITE_ATOMIC
   block/bdev.c:1299:29: note: each undeclared identifier is reported only once for each function it appears in
>> block/bdev.c:1301:21: error: 'struct kstat' has no member named 'write_stream_max'
    1301 |                 stat->write_stream_max = bdev_max_write_streams(bdev);
         |                     ^~


vim +1299 block/bdev.c

  1268	
  1269	/*
  1270	 * Handle STATX_{DIOALIGN, WRITE_ATOMIC} for block devices.
  1271	 */
  1272	void bdev_statx(struct path *path, struct kstat *stat,
  1273			u32 request_mask)
  1274	{
  1275		struct inode *backing_inode;
  1276		struct block_device *bdev;
  1277	
  1278		if (!(request_mask & (STATX_DIOALIGN | STATX_WRITE_ATOMIC)))
  1279			return;
  1280	
  1281		backing_inode = d_backing_inode(path->dentry);
  1282	
  1283		/*
  1284		 * Note that backing_inode is the inode of a block device node file,
  1285		 * not the block device's internal inode.  Therefore it is *not* valid
  1286		 * to use I_BDEV() here; the block device has to be looked up by i_rdev
  1287		 * instead.
  1288		 */
  1289		bdev = blkdev_get_no_open(backing_inode->i_rdev);
  1290		if (!bdev)
  1291			return;
  1292	
  1293		if (request_mask & STATX_DIOALIGN) {
  1294			stat->dio_mem_align = bdev_dma_alignment(bdev) + 1;
  1295			stat->dio_offset_align = bdev_logical_block_size(bdev);
  1296			stat->result_mask |= STATX_DIOALIGN;
  1297		}
  1298	
> 1299		if ((request_mask & STATX_WRITE_STREAM) &&
  1300		    bdev_max_write_streams(bdev)) {
> 1301			stat->write_stream_max = bdev_max_write_streams(bdev);
  1302			stat->result_mask |= STATX_WRITE_STREAM;
  1303		}
  1304	
  1305		if (request_mask & STATX_WRITE_ATOMIC && bdev_can_atomic_write(bdev)) {
  1306			struct request_queue *bd_queue = bdev->bd_queue;
  1307	
  1308			generic_fill_statx_atomic_writes(stat,
  1309				queue_atomic_write_unit_min_bytes(bd_queue),
  1310				queue_atomic_write_unit_max_bytes(bd_queue));
  1311		}
  1312	
  1313		blkdev_put_no_open(bdev);
  1314	}
  1315	

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki