From: Lee Jones <lee@kernel.org>
To: Danilo Krummrich <dakr@kernel.org>
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
gregkh@linuxfoundation.org, ojeda@kernel.org,
alex.gaynor@gmail.com, boqun.feng@gmail.com, gary@garyguo.net,
bjorn3_gh@protonmail.com, benno.lossin@proton.me,
a.hindborg@kernel.org, aliceryhl@google.com, tmgross@umich.edu,
rust-for-linux@vger.kernel.org
Subject: Re: [PATCH v5 0/4] rust: miscdevice: Provide sample driver using the new MiscDevice bindings
Date: Fri, 6 Dec 2024 12:54:30 +0000 [thread overview]
Message-ID: <20241206125430.GB7684@google.com> (raw)
In-Reply-To: <Z1LzOORuFpO0MXAZ@pollux>
On Fri, 06 Dec 2024, Danilo Krummrich wrote:
> On Fri, Dec 06, 2024 at 12:42:11PM +0000, Lee Jones wrote:
> > It has been suggested that the driver should use dev_info() instead of
> > pr_info() however there is currently no scaffolding to successfully pull
> > a 'struct device' out from driver data post register(). This is being
> > worked on and we will convert this over in due course.
>
> I think you're going too fast with this series.
>
> Please address the comments you receive before sending out new versions.
>
> Also, please document the changes you have made from one version to the next,
> otherwise it's gonna be very hard to review this.
I can add a change log.
What comments were missed?
--
Lee Jones [李琼斯]
next prev parent reply other threads:[~2024-12-06 12:54 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 12:42 [PATCH v5 0/4] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Lee Jones
2024-12-06 12:42 ` [PATCH v5 1/4] Documentation: ioctl-number: Carve out some identifiers for use by sample drivers Lee Jones
2024-12-06 12:42 ` [PATCH v5 2/4] samples: rust: Provide example using the new Rust MiscDevice abstraction Lee Jones
2024-12-06 12:42 ` [PATCH v5 3/4] sample: rust_misc_device: Demonstrate additional get/set value functionality Lee Jones
2024-12-06 12:59 ` Greg KH
2024-12-06 13:04 ` Lee Jones
2024-12-06 13:06 ` Lee Jones
2024-12-06 13:10 ` Greg KH
2024-12-06 13:17 ` Lee Jones
2024-12-06 12:42 ` [PATCH v5 4/4] MAINTAINERS: Add Rust Misc Sample to MISC entry Lee Jones
2024-12-06 12:51 ` [PATCH v5 0/4] rust: miscdevice: Provide sample driver using the new MiscDevice bindings Danilo Krummrich
2024-12-06 12:54 ` Lee Jones [this message]
2024-12-06 13:05 ` Danilo Krummrich
2024-12-06 13:14 ` Lee Jones
2024-12-06 13:34 ` Danilo Krummrich
2024-12-06 16:49 ` Lee Jones
2024-12-06 18:29 ` Danilo Krummrich
2024-12-06 22:06 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241206125430.GB7684@google.com \
--to=lee@kernel.org \
--cc=a.hindborg@kernel.org \
--cc=alex.gaynor@gmail.com \
--cc=aliceryhl@google.com \
--cc=arnd@arndb.de \
--cc=benno.lossin@proton.me \
--cc=bjorn3_gh@protonmail.com \
--cc=boqun.feng@gmail.com \
--cc=dakr@kernel.org \
--cc=gary@garyguo.net \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=ojeda@kernel.org \
--cc=rust-for-linux@vger.kernel.org \
--cc=tmgross@umich.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.