Re: [PATCH V5 net-next 1/8] debugfs: Add debugfs_create_devm_dir() helper

[kernel test robot <lkp@intel.com>]

BCC: lkp@intel.com
CC: oe-kbuild-all@lists.linux.dev
In-Reply-To: <20241206111629.3521865-2-shaojijie@huawei.com>
References: <20241206111629.3521865-2-shaojijie@huawei.com>
TO: Jijie Shao <shaojijie@huawei.com>
TO: davem@davemloft.net
TO: edumazet@google.com
TO: kuba@kernel.org
TO: pabeni@redhat.com
TO: andrew+netdev@lunn.ch
TO: horms@kernel.org
TO: gregkh@linuxfoundation.org
CC: shenjian15@huawei.com
CC: wangpeiyang1@huawei.com
CC: liuyonglong@huawei.com
CC: chenhao418@huawei.com
CC: sudongming1@huawei.com
CC: xujunsheng@huawei.com
CC: shiyongbang@huawei.com
CC: libaihan@huawei.com
CC: jonathan.cameron@huawei.com
CC: shameerali.kolothum.thodi@huawei.com
CC: salil.mehta@huawei.com
CC: netdev@vger.kernel.org
CC: linux-kernel@vger.kernel.org
CC: shaojijie@huawei.com
CC: hkelam@marvell.com

Hi Jijie,

kernel test robot noticed the following build warnings:

[auto build test WARNING on net-next/main]

url:    https://github.com/intel-lab-lkp/linux/commits/Jijie-Shao/debugfs-Add-debugfs_create_devm_dir-helper/20241206-192734
base:   net-next/main
patch link:    https://lore.kernel.org/r/20241206111629.3521865-2-shaojijie%40huawei.com
patch subject: [PATCH V5 net-next 1/8] debugfs: Add debugfs_create_devm_dir() helper
:::::: branch date: 20 hours ago
:::::: commit date: 20 hours ago
config: i386-randconfig-141-20241206 (https://download.01.org/0day-ci/archive/20241207/202412071523.XnSXmPPZ-lkp@intel.com/config)
compiler: clang version 19.1.3 (https://github.com/llvm/llvm-project ab51eccf88f5321e7c60591c5546b254b6afab99)

If you fix the issue in a separate patch/commit (i.e. not just a new version of
the same patch/commit), kindly add following tags
| Reported-by: kernel test robot <lkp@intel.com>
| Reported-by: Dan Carpenter <error27@gmail.com>
| Closes: https://lore.kernel.org/r/202412071523.XnSXmPPZ-lkp@intel.com/

smatch warnings:
fs/debugfs/inode.c:643 debugfs_create_devm_dir() warn: unchecked 'ERR_PTR'

vim +/ERR_PTR +643 fs/debugfs/inode.c

d44644eefac450 Jijie Shao 2024-12-06  619  
d44644eefac450 Jijie Shao 2024-12-06  620  /**
d44644eefac450 Jijie Shao 2024-12-06  621   * debugfs_create_devm_dir - Managed debugfs_create_dir()
d44644eefac450 Jijie Shao 2024-12-06  622   * @dev: Device that owns the action
d44644eefac450 Jijie Shao 2024-12-06  623   * @name: a pointer to a string containing the name of the directory to
d44644eefac450 Jijie Shao 2024-12-06  624   *        create.
d44644eefac450 Jijie Shao 2024-12-06  625   * @parent: a pointer to the parent dentry for this file.  This should be a
d44644eefac450 Jijie Shao 2024-12-06  626   *          directory dentry if set.  If this parameter is NULL, then the
d44644eefac450 Jijie Shao 2024-12-06  627   *          directory will be created in the root of the debugfs filesystem.
d44644eefac450 Jijie Shao 2024-12-06  628   * Managed debugfs_create_dir(). dentry will automatically be remove on
d44644eefac450 Jijie Shao 2024-12-06  629   * driver detach.
d44644eefac450 Jijie Shao 2024-12-06  630   */
d44644eefac450 Jijie Shao 2024-12-06  631  struct dentry *debugfs_create_devm_dir(struct device *dev, const char *name,
d44644eefac450 Jijie Shao 2024-12-06  632  				       struct dentry *parent)
d44644eefac450 Jijie Shao 2024-12-06  633  {
d44644eefac450 Jijie Shao 2024-12-06  634  	struct dentry *dentry;
d44644eefac450 Jijie Shao 2024-12-06  635  	int ret;
d44644eefac450 Jijie Shao 2024-12-06  636  
d44644eefac450 Jijie Shao 2024-12-06  637  	dentry = debugfs_create_dir(name, parent);
d44644eefac450 Jijie Shao 2024-12-06  638  	if (IS_ERR(dentry))
d44644eefac450 Jijie Shao 2024-12-06  639  		return dentry;
d44644eefac450 Jijie Shao 2024-12-06  640  
d44644eefac450 Jijie Shao 2024-12-06  641  	ret = devm_add_action_or_reset(dev, debugfs_remove_devm, dentry);
d44644eefac450 Jijie Shao 2024-12-06  642  	if (ret)
d44644eefac450 Jijie Shao 2024-12-06 @643  		ERR_PTR(ret);
d44644eefac450 Jijie Shao 2024-12-06  644  
d44644eefac450 Jijie Shao 2024-12-06  645  	return dentry;
d44644eefac450 Jijie Shao 2024-12-06  646  }
d44644eefac450 Jijie Shao 2024-12-06  647  EXPORT_SYMBOL_GPL(debugfs_create_devm_dir);
d44644eefac450 Jijie Shao 2024-12-06  648  

-- 
0-DAY CI Kernel Test Service
https://github.com/intel/lkp-tests/wiki