From: Jakub Kicinski <kuba@kernel.org>
To: Yafang Shao <laoar.shao@gmail.com>
Cc: saeedm@nvidia.com, tariqt@nvidia.com, leon@kernel.org,
gal@nvidia.com, netdev@vger.kernel.org,
linux-rdma@vger.kernel.org,
Tariq Toukan <ttoukan.linux@gmail.com>
Subject: Re: [PATCH v3 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors
Date: Sat, 7 Dec 2024 17:38:08 -0800 [thread overview]
Message-ID: <20241207173808.5866b5a6@kernel.org> (raw)
In-Reply-To: <20241206090328.4758-1-laoar.shao@gmail.com>
On Fri, 6 Dec 2024 17:03:28 +0800 Yafang Shao wrote:
> We observed a high number of rx_discards_phy events on some servers when
> running `ethtool -S`. However, this important counter is not currently
> reflected in the /proc/net/dev statistics file, making it challenging to
> monitor effectively.
>
> Since rx_fifo_errors represents receive FIFO errors on this network
> deivice, it makes sense to include rx_discards_phy in this counter to
> enhance monitoring visibility. This change will help administrators track
> these events more effectively through standard interfaces.
It's not a standard if there is no definition applicable across vendors.
Count it as generic rx_dropped. If you disagree with me please carry
this tag on future versions:
Nacked-by: Jakub Kicinski <kuba@kernel.org>
--
pw-bot: cr
next prev parent reply other threads:[~2024-12-08 1:38 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 9:03 [PATCH v3 net-next] net/mlx5e: Report rx_discards_phy via rx_fifo_errors Yafang Shao
2024-12-08 1:38 ` Jakub Kicinski [this message]
2024-12-08 6:01 ` Yafang Shao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241207173808.5866b5a6@kernel.org \
--to=kuba@kernel.org \
--cc=gal@nvidia.com \
--cc=laoar.shao@gmail.com \
--cc=leon@kernel.org \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.