All of lore.kernel.org
 help / color / mirror / Atom feed
From: cel@kernel.org
To: Zorro Lang <zlang@redhat.com>
Cc: <linux-fsdevel@vger.kernel.org>, Chuck Lever <chuck.lever@oracle.com>
Subject: [PATCH] fstests: disable generic duperemove tests for NFS and others
Date: Sun,  8 Dec 2024 13:07:18 -0500	[thread overview]
Message-ID: <20241208180718.930987-1-cel@kernel.org> (raw)

From: Chuck Lever <chuck.lever@oracle.com>

On NFS mounts, at least, generic/559, 560, and 561 run for a very
long time, and usually fail.

The above tests already gate on whether duperemove is installed on
the test system, but when fstests is installed as part of an
automated workflow designed to handle many filesystem types,
duperemove is installed by default.

duperemove(8) states:

  Deduplication is currently only supported by the btrfs and xfs
  filesystem.

Ensure that the generic dedupe tests are run on only filesystems
where duperemove is known to work.

Signed-off-by: Chuck Lever <chuck.lever@oracle.com>
---
 tests/generic/559 | 1 +
 tests/generic/560 | 1 +
 tests/generic/561 | 1 +
 3 files changed, 3 insertions(+)

diff --git a/tests/generic/559 b/tests/generic/559
index 28cf2e1a32c2..cf80be92142d 100755
--- a/tests/generic/559
+++ b/tests/generic/559
@@ -13,6 +13,7 @@ _begin_fstest auto stress dedupe
 . ./common/filter
 . ./common/reflink
 
+_supported_fs btrfs xfs
 _require_scratch_duperemove
 
 fssize=$((2 * 1024 * 1024 * 1024))
diff --git a/tests/generic/560 b/tests/generic/560
index 067d3ec0049e..a94b512efda1 100755
--- a/tests/generic/560
+++ b/tests/generic/560
@@ -15,6 +15,7 @@ _begin_fstest auto stress dedupe
 . ./common/filter
 . ./common/reflink
 
+_supported_fs btrfs xfs
 _require_scratch_duperemove
 
 _scratch_mkfs > $seqres.full 2>&1
diff --git a/tests/generic/561 b/tests/generic/561
index afe727ac56cb..da5f111c5b23 100755
--- a/tests/generic/561
+++ b/tests/generic/561
@@ -28,6 +28,7 @@ _cleanup()
 . ./common/filter
 . ./common/reflink
 
+_supported_fs btrfs xfs
 _require_scratch_duperemove
 
 _scratch_mkfs > $seqres.full 2>&1
-- 
2.47.0


             reply	other threads:[~2024-12-08 18:07 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-08 18:07 cel [this message]
2024-12-08 20:01 ` [PATCH] fstests: disable generic duperemove tests for NFS and others Dave Chinner
2024-12-09 13:49 ` Christoph Hellwig
2024-12-09 15:00   ` Chuck Lever
2024-12-09 15:07     ` Christoph Hellwig
2024-12-09 19:35       ` Chuck Lever
2024-12-09 18:45 ` Zorro Lang
2024-12-09 18:50   ` Chuck Lever

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20241208180718.930987-1-cel@kernel.org \
    --to=cel@kernel.org \
    --cc=chuck.lever@oracle.com \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=zlang@redhat.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.