From: Christoph Hellwig <hch@lst.de>
To: Yongsoo Joo <ysjoo@kookmin.ac.kr>
Cc: Keith Busch <kbusch@kernel.org>,
axboe@kernel.dk, hch@lst.de, sagi@grimberg.me,
linux-nvme@lists.infradead.org
Subject: Re: [PATCH] nvme: fix return type of nvme_poll()
Date: Mon, 9 Dec 2024 08:58:36 +0100 [thread overview]
Message-ID: <20241209075836.GA24705@lst.de> (raw)
In-Reply-To: <Z1U7npo/DINh2MR9@ubuntu>
On Sun, Dec 08, 2024 at 06:24:30AM +0000, Yongsoo Joo wrote:
> I agree that all the "current" interested callers seem to expect
> boolean-like return values from nvme_poll(). However, the return
> type of both nvme_poll() and nvme_poll_cq() is int, and
> nvme_poll_cq() actually returns the number of processed CQEs.
Maybe add a patch to switch the poll method to return bool instead?
next prev parent reply other threads:[~2024-12-09 7:58 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-07 4:55 [PATCH] nvme: fix return type of nvme_poll() Yongsoo Joo
2024-12-08 3:13 ` Keith Busch
2024-12-08 6:24 ` Yongsoo Joo
2024-12-09 7:58 ` Christoph Hellwig [this message]
2024-12-09 13:28 ` Yongsoo Joo
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209075836.GA24705@lst.de \
--to=hch@lst.de \
--cc=axboe@kernel.dk \
--cc=kbusch@kernel.org \
--cc=linux-nvme@lists.infradead.org \
--cc=sagi@grimberg.me \
--cc=ysjoo@kookmin.ac.kr \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.