From: Jakub Kicinski <kuba@kernel.org>
To: Tariq Toukan <ttoukan.linux@gmail.com>
Cc: Tariq Toukan <tariqt@nvidia.com>,
"David S. Miller" <davem@davemloft.net>,
Paolo Abeni <pabeni@redhat.com>,
Eric Dumazet <edumazet@google.com>,
Andrew Lunn <andrew+netdev@lunn.ch>,
Leon Romanovsky <leonro@nvidia.com>,
netdev@vger.kernel.org, Saeed Mahameed <saeedm@nvidia.com>,
Gal Pressman <gal@nvidia.com>,
linux-rdma@vger.kernel.org, Carolina Jubran <cjubran@nvidia.com>,
Cosmin Ratiu <cratiu@nvidia.com>, Jiri Pirko <jiri@nvidia.com>
Subject: Re: [PATCH net-next V5 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management
Date: Mon, 9 Dec 2024 13:27:34 -0800 [thread overview]
Message-ID: <20241209132734.2039dead@kernel.org> (raw)
In-Reply-To: <89652b98-65a8-4a97-a2e2-6c36acf7c663@gmail.com>
On Mon, 9 Dec 2024 23:03:04 +0200 Tariq Toukan wrote:
> >> + tc_index = nla_get_u8(tb[DEVLINK_ATTR_RATE_TC_INDEX]);
> >> +
> >> + if (tc_index >= IEEE_8021QAZ_MAX_TCS) {
> >
> > This can't be enforced by the policy?
> >
>
> If we enforce by policy we need to use the constant 7, not the macro
> IEEE_8021QAZ_MAX_TCS-1.
> I'll keep it.
The spec should support using "foreign constants"
Off the top of my head - you can define the ieee-8021qaz-max-tcs contant
as if you were defining a devlink constant, then add a header:
attribute. This will tell C codegen to include that header instead of
generating the definition.
next prev parent reply other threads:[~2024-12-09 21:27 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-04 22:09 [PATCH net-next V5 00/11] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 01/11] net/mlx5: ifc: Reorganize mlx5_ifc_flow_table_context_bits Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 02/11] net/mlx5: Add ConnectX-8 device to ifc Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 03/11] net/mlx5: Add support for new scheduling elements Tariq Toukan
2024-12-04 22:09 ` [PATCH mlx5-next V5 04/11] net/mlx5: qos: Add ifc support for cross-esw scheduling Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 05/11] net/mlx5: DR, Expand SWS STE callbacks and consolidate common structs Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 06/11] net/mlx5: DR, Add support for ConnectX-8 steering Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 07/11] devlink: Extend devlink rate API with traffic classes bandwidth management Tariq Toukan
2024-12-07 2:10 ` Jakub Kicinski
2024-12-09 21:03 ` Tariq Toukan
2024-12-09 21:27 ` Jakub Kicinski [this message]
2025-01-20 11:55 ` Carolina Jubran
2025-01-20 18:14 ` Jakub Kicinski
2025-01-21 12:36 ` Carolina Jubran
2025-01-22 12:48 ` Carolina Jubran
2025-01-22 14:30 ` Jakub Kicinski
2025-02-05 6:22 ` Tariq Toukan
2025-02-05 6:56 ` Gal Pressman
2025-02-05 8:02 ` Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 08/11] net/mlx5: Add no-op implementation for setting tc-bw on rate objects Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 09/11] net/mlx5: Add support for setting tc-bw on nodes Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 10/11] net/mlx5: Add traffic class scheduling support for vport QoS Tariq Toukan
2024-12-04 22:09 ` [PATCH net-next V5 11/11] net/mlx5: Manage TC arbiter nodes and implement full support for tc-bw Tariq Toukan
2024-12-05 9:23 ` [PATCH net-next V5 00/11] net/mlx5: ConnectX-8 SW Steering + Rate management on traffic classes Leon Romanovsky
2024-12-07 2:13 ` Jakub Kicinski
2024-12-09 19:32 ` Tariq Toukan
2024-12-09 21:41 ` Jakub Kicinski
2024-12-11 9:49 ` Cosmin Ratiu
2024-12-12 1:49 ` Jakub Kicinski
2024-12-13 13:42 ` Cosmin Ratiu
2024-12-17 5:45 ` Jakub Kicinski
2024-12-17 15:14 ` Cosmin Ratiu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209132734.2039dead@kernel.org \
--to=kuba@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=cjubran@nvidia.com \
--cc=cratiu@nvidia.com \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=gal@nvidia.com \
--cc=jiri@nvidia.com \
--cc=leonro@nvidia.com \
--cc=linux-rdma@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=saeedm@nvidia.com \
--cc=tariqt@nvidia.com \
--cc=ttoukan.linux@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.