From: Jakub Kicinski <kuba@kernel.org>
To: "Toke Høiland-Jørgensen" <toke@redhat.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"Toke Høiland-Jørgensen" <toke@toke.dk>,
"Jamal Hadi Salim" <jhs@mojatatu.com>,
"Cong Wang" <xiyou.wangcong@gmail.com>,
"Jiri Pirko" <jiri@resnulli.us>,
netdev@vger.kernel.org, cake@lists.bufferbloat.net
Subject: Re: [PATCH net-next] net_sched: sch_cake: Add drop reasons
Date: Mon, 9 Dec 2024 15:51:57 -0800 [thread overview]
Message-ID: <20241209155157.6a817bc5@kernel.org> (raw)
In-Reply-To: <20241209-cake-drop-reason-v1-1-19205f6d1f19@redhat.com>
On Mon, 09 Dec 2024 13:02:18 +0100 Toke Høiland-Jørgensen wrote:
> Add three qdisc-specific drop reasons for sch_cake:
>
> 1) SKB_DROP_REASON_CAKE_CONGESTED
> Whenever a packet is dropped by the CAKE AQM algorithm because
> congestion is detected.
>
> 2) SKB_DROP_REASON_CAKE_FLOOD
> Whenever a packet is dropped by the flood protection part of the
> CAKE AQM algorithm (BLUE).
>
> 3) SKB_DROP_REASON_CAKE_OVERLIMIT
> Whenever the total queue limit for a CAKE instance is exceeded and a
> packet is dropped to make room.
Eric's patch was adding fairly FQ-specific reasons, other than flood
this seems like generic AQM stuff, no? From a very quick look the
congestion looks like fairly standard AQM, overlimit is also typical
for qdics?
next prev parent reply other threads:[~2024-12-09 23:51 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-09 12:02 [PATCH net-next] net_sched: sch_cake: Add drop reasons Toke Høiland-Jørgensen
2024-12-09 13:26 ` Eric Dumazet
2024-12-09 23:00 ` Jamal Hadi Salim
2024-12-09 23:14 ` [Cake] " Dave Taht
2024-12-09 23:51 ` Jakub Kicinski [this message]
2024-12-10 0:25 ` Dave Taht
2024-12-10 8:42 ` Toke Høiland-Jørgensen
2024-12-10 9:10 ` Jonathan Morton
2024-12-11 1:28 ` Jakub Kicinski
2024-12-11 9:55 ` Toke Høiland-Jørgensen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241209155157.6a817bc5@kernel.org \
--to=kuba@kernel.org \
--cc=cake@lists.bufferbloat.net \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jhs@mojatatu.com \
--cc=jiri@resnulli.us \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=toke@redhat.com \
--cc=toke@toke.dk \
--cc=xiyou.wangcong@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.