All of lore.kernel.org
 help / color / mirror / Atom feed
From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: "André Draszik" <andre.draszik@linaro.org>
Cc: Thinh Nguyen <Thinh.Nguyen@synopsys.com>,
	linux-usb@vger.kernel.org, linux-kernel@vger.kernel.org,
	stable@vger.kernel.org
Subject: Re: [PATCH for stable 5.4 v2] usb: dwc3: gadget: fix writing NYET threshold
Date: Mon, 9 Dec 2024 13:05:39 +0100	[thread overview]
Message-ID: <2024120926-uncolored-lip-b571@gregkh> (raw)
In-Reply-To: <20241209-dwc3-nyet-fix-5-4-v2-1-66a67836ae70@linaro.org>

On Mon, Dec 09, 2024 at 11:50:57AM +0000, André Draszik wrote:
> Before writing a new value to the register, the old value needs to be
> masked out for the new value to be programmed as intended, because at
> least in some cases the reset value of that field is 0xf (max value).
> 
> At the moment, the dwc3 core initialises the threshold to the maximum
> value (0xf), with the option to override it via a DT. No upstream DTs
> seem to override it, therefore this commit doesn't change behaviour for
> any upstream platform. Nevertheless, the code should be fixed to have
> the desired outcome.
> 
> Do so.
> 
> Fixes: 80caf7d21adc ("usb: dwc3: add lpm erratum support")
> Cc: stable@vger.kernel.org # 5.4 (needs adjustment for 5.10+)
> Signed-off-by: André Draszik <andre.draszik@linaro.org>
> ---
> * has been marked as v2, to be in line with the 5.10+ patch
> * for stable-5.10+, the if() test is slightly different, so a separate
>   patch has been sent for it for the patch to apply.

What is the git id of this in Linus's tree?

thanks,

greg k-h

  reply	other threads:[~2024-12-09 12:05 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2024-12-09 11:50 [PATCH for stable 5.4 v2] usb: dwc3: gadget: fix writing NYET threshold André Draszik
2024-12-09 12:05 ` Greg Kroah-Hartman [this message]
2024-12-09 12:12   ` André Draszik
2024-12-09 12:23     ` Greg Kroah-Hartman
2024-12-09 14:35 ` Sasha Levin

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2024120926-uncolored-lip-b571@gregkh \
    --to=gregkh@linuxfoundation.org \
    --cc=Thinh.Nguyen@synopsys.com \
    --cc=andre.draszik@linaro.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-usb@vger.kernel.org \
    --cc=stable@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.