From: Jakub Kicinski <kuba@kernel.org>
To: Yuyang Huang <yuyanghuang@google.com>
Cc: "David S. Miller" <davem@davemloft.net>,
"Eric Dumazet" <edumazet@google.com>,
"Paolo Abeni" <pabeni@redhat.com>,
"Simon Horman" <horms@kernel.org>,
"David Ahern" <dsahern@kernel.org>,
roopa@cumulusnetworks.com, jiri@resnulli.us,
stephen@networkplumber.org, jimictw@google.com, prohr@google.com,
liuhangbin@gmail.com, nicolas.dichtel@6wind.com, andrew@lunn.ch,
netdev@vger.kernel.org, "Maciej Żenczykowski" <maze@google.com>,
"Lorenzo Colitti" <lorenzo@google.com>,
"Patrick Ruddy" <pruddy@vyatta.att-mail.com>
Subject: Re: [PATCH net-next, v5] netlink: add IGMP/MLD join/leave notifications
Date: Tue, 10 Dec 2024 16:50:24 -0800 [thread overview]
Message-ID: <20241210165024.07baa835@kernel.org> (raw)
In-Reply-To: <CADXeF1FNGMxBHV8_mvU99Xjj-40BcdG44MtbLNywwr1X8CqHkw@mail.gmail.com>
On Tue, 10 Dec 2024 12:19:11 +0900 Yuyang Huang wrote:
> >u8 scope = RT_SCOPE_UNIVERSE;
> >struct nlmsghdr *nlh;
> >if (ipv6_addr_scope(&ifmca->mca_addr) & IFA_SITE)
> scope = RT_SCOPE_SITE;
>
> Is it acceptable, or should I update the old logic to always set
> ‘RT_SCOPE_UNIVERSE’?
TBH I'm not an expert on IPv6 address scopes, why do we want to ignore
it now? Some commit or RFC we can refer to?
Perhaps you could add a new member to inet6_fill_args to force the
scope to always be set to universe?
next prev parent reply other threads:[~2024-12-11 0:50 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 4:10 [PATCH net-next, v5] netlink: add IGMP/MLD join/leave notifications Yuyang Huang
2024-12-06 14:56 ` Nicolas Dichtel
2024-12-10 1:20 ` Hangbin Liu
2024-12-10 2:25 ` Jakub Kicinski
2024-12-10 3:19 ` Yuyang Huang
2024-12-10 4:32 ` Yuyang Huang
2024-12-11 0:50 ` Jakub Kicinski [this message]
2024-12-11 1:43 ` Yuyang Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210165024.07baa835@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=horms@kernel.org \
--cc=jimictw@google.com \
--cc=jiri@resnulli.us \
--cc=liuhangbin@gmail.com \
--cc=lorenzo@google.com \
--cc=maze@google.com \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=pabeni@redhat.com \
--cc=prohr@google.com \
--cc=pruddy@vyatta.att-mail.com \
--cc=roopa@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=yuyanghuang@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.