From: Jakub Kicinski <kuba@kernel.org>
To: Paolo Abeni <pabeni@redhat.com>
Cc: netdev@vger.kernel.org, "David S. Miller" <davem@davemloft.net>,
David Ahern <dsahern@kernel.org>,
Eric Dumazet <edumazet@google.com>,
Simon Horman <horms@kernel.org>,
Fred Chen <fred.cc@alibaba-inc.com>,
Cambda Zhu <cambda@linux.alibaba.com>,
Willem de Bruijn <willemb@google.com>,
Philo Lu <lulie@linux.alibaba.com>,
Stefano Brivio <sbrivio@redhat.com>
Subject: Re: [PATCH net] udp: fix l4 hash after reconnect
Date: Tue, 10 Dec 2024 16:59:28 -0800 [thread overview]
Message-ID: <20241210165928.6934188e@kernel.org> (raw)
In-Reply-To: <4761e466ab9f7542c68cdc95f248987d127044d2.1733499715.git.pabeni@redhat.com>
On Fri, 6 Dec 2024 16:49:14 +0100 Paolo Abeni wrote:
> After the blamed commit below, udp_rehash() is supposed to be called
> with both local and remote addresses set.
>
> Currently that is already the case for IPv6 sockets, but for IPv4 the
> destination address is updated after rehashing.
>
> Address the issue moving the destination address and port initialization
> before rehashing.
>
> Fixes: 1b29a730ef8b ("ipv6/udp: Add 4-tuple hash for connected socket")
> Signed-off-by: Paolo Abeni <pabeni@redhat.com>
I feel obliged to point out a lack of selftest both here and the series
under Fixes :(
next prev parent reply other threads:[~2024-12-11 0:59 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 15:49 [PATCH net] udp: fix l4 hash after reconnect Paolo Abeni
2024-12-06 15:57 ` Eric Dumazet
2024-12-06 16:01 ` Eric Dumazet
2024-12-06 16:23 ` Paolo Abeni
2024-12-07 2:34 ` Philo Lu
2024-12-10 8:32 ` Paolo Abeni
2024-12-10 10:45 ` Philo Lu
2024-12-31 7:55 ` Philo Lu
2025-01-07 7:56 ` Paolo Abeni
2025-01-08 12:25 ` Philo Lu
2024-12-10 14:40 ` patchwork-bot+netdevbpf
2024-12-11 0:59 ` Jakub Kicinski [this message]
2024-12-17 12:16 ` Philo Lu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210165928.6934188e@kernel.org \
--to=kuba@kernel.org \
--cc=cambda@linux.alibaba.com \
--cc=davem@davemloft.net \
--cc=dsahern@kernel.org \
--cc=edumazet@google.com \
--cc=fred.cc@alibaba-inc.com \
--cc=horms@kernel.org \
--cc=lulie@linux.alibaba.com \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=sbrivio@redhat.com \
--cc=willemb@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.