From: Jakub Kicinski <kuba@kernel.org>
To: Mateusz Polchlopek <mateusz.polchlopek@intel.com>
Cc: Ming Yu <a0282524688@gmail.com>, <tmyu0@nuvoton.com>,
<lee@kernel.org>, <linus.walleij@linaro.org>, <brgl@bgdev.pl>,
<andi.shyti@kernel.org>, <mkl@pengutronix.de>,
<mailhol.vincent@wanadoo.fr>, <andrew+netdev@lunn.ch>,
<davem@davemloft.net>, <edumazet@google.com>, <pabeni@redhat.com>,
<wim@linux-watchdog.org>, <linux@roeck-us.net>,
<jdelvare@suse.com>, <alexandre.belloni@bootlin.com>,
<linux-kernel@vger.kernel.org>, <linux-gpio@vger.kernel.org>,
<linux-i2c@vger.kernel.org>, <linux-can@vger.kernel.org>,
<netdev@vger.kernel.org>, <linux-watchdog@vger.kernel.org>,
<linux-hwmon@vger.kernel.org>, <linux-rtc@vger.kernel.org>
Subject: Re: [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694
Date: Tue, 10 Dec 2024 17:56:23 -0800 [thread overview]
Message-ID: <20241210175623.748da1b8@kernel.org> (raw)
In-Reply-To: <2d6e82ff-9f68-427e-a8a6-8dd31b3c94e4@intel.com>
On Tue, 10 Dec 2024 11:57:41 +0100 Mateusz Polchlopek wrote:
> > +int nct6694_read_msg(struct nct6694 *nct6694, u8 mod, u16 offset,
> > + u16 length, void *buf)
> > +{
> > + struct nct6694_cmd_header *cmd_header = nct6694->cmd_header;
> > + struct nct6694_response_header *response_header = nct6694->response_header;
>
> RCT violation
This code is not under net not drivers/net
As a general rule please focus on functional review, formatting and
process issues are harder to judge unless you read all of the mailing
list traffic.
next prev parent reply other threads:[~2024-12-11 1:56 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-10 10:45 [PATCH v3 0/7] Add Nuvoton NCT6694 MFD drivers Ming Yu
2024-12-10 10:45 ` [PATCH v3 1/7] mfd: Add core driver for Nuvoton NCT6694 Ming Yu
2024-12-10 10:57 ` Mateusz Polchlopek
2024-12-11 1:56 ` Jakub Kicinski [this message]
2024-12-11 7:16 ` Mateusz Polchlopek
2024-12-10 14:38 ` Krzysztof Kozlowski
2024-12-12 5:27 ` Ming Yu
2024-12-11 16:44 ` Christophe JAILLET
2024-12-12 7:01 ` Ming Yu
2024-12-12 7:13 ` Christophe JAILLET
2024-12-20 12:45 ` Linus Walleij
2024-12-23 2:04 ` Ming Yu
2024-12-10 10:45 ` [PATCH v3 2/7] gpio: Add Nuvoton NCT6694 GPIO support Ming Yu
2024-12-10 12:46 ` Bartosz Golaszewski
2024-12-12 6:58 ` Ming Yu
2024-12-20 12:41 ` Linus Walleij
2024-12-23 2:02 ` Ming Yu
2024-12-10 10:45 ` [PATCH v3 3/7] i2c: Add Nuvoton NCT6694 I2C support Ming Yu
2024-12-26 0:43 ` Andi Shyti
2024-12-26 2:06 ` Ming Yu
2024-12-26 9:25 ` Andi Shyti
2024-12-10 10:45 ` [PATCH v3 4/7] can: Add Nuvoton NCT6694 CAN support Ming Yu
2024-12-11 9:59 ` Marc Kleine-Budde
2024-12-11 15:25 ` Vincent Mailhol
2024-12-16 6:58 ` Ming Yu
2024-12-16 17:14 ` Vincent Mailhol
2024-12-16 6:21 ` Ming Yu
2024-12-23 9:03 ` Ming Yu
2024-12-10 10:45 ` [PATCH v3 5/7] watchdog: Add Nuvoton NCT6694 WDT support Ming Yu
2024-12-10 15:22 ` Guenter Roeck
2024-12-12 6:26 ` Ming Yu
2024-12-10 10:45 ` [PATCH v3 6/7] hwmon: Add Nuvoton NCT6694 HWMON support Ming Yu
2024-12-10 15:58 ` Guenter Roeck
2024-12-12 7:09 ` Ming Yu
2024-12-12 16:10 ` Vincent Mailhol
2024-12-16 7:04 ` Ming Yu
2024-12-10 10:45 ` [PATCH v3 7/7] rtc: Add Nuvoton NCT6694 RTC support Ming Yu
2024-12-16 10:41 ` Alexandre Belloni
2024-12-23 1:50 ` Ming Yu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210175623.748da1b8@kernel.org \
--to=kuba@kernel.org \
--cc=a0282524688@gmail.com \
--cc=alexandre.belloni@bootlin.com \
--cc=andi.shyti@kernel.org \
--cc=andrew+netdev@lunn.ch \
--cc=brgl@bgdev.pl \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=jdelvare@suse.com \
--cc=lee@kernel.org \
--cc=linus.walleij@linaro.org \
--cc=linux-can@vger.kernel.org \
--cc=linux-gpio@vger.kernel.org \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-rtc@vger.kernel.org \
--cc=linux-watchdog@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=mailhol.vincent@wanadoo.fr \
--cc=mateusz.polchlopek@intel.com \
--cc=mkl@pengutronix.de \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=tmyu0@nuvoton.com \
--cc=wim@linux-watchdog.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.