From: Jakub Kicinski <kuba@kernel.org>
To: Wei Fang <wei.fang@nxp.com>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"hkallweit1@gmail.com" <hkallweit1@gmail.com>,
"linux@armlinux.org.uk" <linux@armlinux.org.uk>,
"davem@davemloft.net" <davem@davemloft.net>,
"edumazet@google.com" <edumazet@google.com>,
"pabeni@redhat.com" <pabeni@redhat.com>,
"florian.fainelli@broadcom.com" <florian.fainelli@broadcom.com>,
"heiko.stuebner@cherry.de" <heiko.stuebner@cherry.de>,
"fank.li@nxp.com" <fank.li@nxp.com>,
"netdev@vger.kernel.org" <netdev@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"imx@lists.linux.dev" <imx@lists.linux.dev>
Subject: Re: [PATCH v3 net] net: phy: micrel: Dynamically control external clock of KSZ PHY
Date: Tue, 10 Dec 2024 17:59:28 -0800 [thread overview]
Message-ID: <20241210175928.39505f6c@kernel.org> (raw)
In-Reply-To: <PAXPR04MB8510008EBDA6EB1CF89246F8883E2@PAXPR04MB8510.eurprd04.prod.outlook.com>
On Wed, 11 Dec 2024 01:49:50 +0000 Wei Fang wrote:
> > I may be missing something but if you don't need to disable the generic
> > clock you can put the disable into the if () block for rmii-ref ?
>
> For my case, it's fine to disable rmii-ref because this clock source is always
> enabled in FEC driver. But the commit 99ac4cbcc2a5 ("net: phy: micrel: allow
> usage of generic ethernet-phy clock") was applied a year ago, so I raised a
> concern in V2 [1], if a new platform only enables rmii-ref in the PHY driver,
> disabling rmii-ref after getting the clock rate will cause problem, which will
> cause RMII to not work. I'm not sure if any platform actually does this, if so
> the following changes will be a more serious problem.
Put more of this explanation into the commit message and resend.
If it convinces Andrew we can apply.
next prev parent reply other threads:[~2024-12-11 1:59 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-12-06 1:21 [PATCH v3 net] net: phy: micrel: Dynamically control external clock of KSZ PHY Wei Fang
2024-12-10 2:14 ` Jakub Kicinski
2024-12-10 2:45 ` Wei Fang
2024-12-11 0:43 ` Jakub Kicinski
2024-12-11 1:49 ` Wei Fang
2024-12-11 1:59 ` Jakub Kicinski [this message]
2024-12-11 2:02 ` Wei Fang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20241210175928.39505f6c@kernel.org \
--to=kuba@kernel.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=edumazet@google.com \
--cc=fank.li@nxp.com \
--cc=florian.fainelli@broadcom.com \
--cc=heiko.stuebner@cherry.de \
--cc=hkallweit1@gmail.com \
--cc=imx@lists.linux.dev \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=wei.fang@nxp.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.